[core] Fixed a data race on listener's config.

maxsharabayko · yomnes0 · maxsharabayko · commit 4270a11a73a5 · 2024-08-07T17:07:02.000+02:00
Co-authored-by: yomnes0 &lt;yomnes@haivision.com&gt;
diff --git a/srtcore/api.cpp b/srtcore/api.cpp
@@ -537,6 +537,8 @@ int srt::CUDTUnited::newConnection(const SRTSOCKET     listen,
 
     try
     {
+        // Protect the config of the listener socket from a data race.
+        ScopedLock lck(ls->core().m_ConnectionLock);
         ns = new CUDTSocket(*ls);
         // No need to check the peer, this is the address from which the request has come.
         ns->m_PeerAddr = peer;

Original file line number	Diff line number	Diff line change
`@@ -537,6 +537,8 @@ int srt::CUDTUnited::newConnection(const SRTSOCKET listen,`
`537`	`537`
`538`	`538`	`try`
`539`	`539`	`{`
	`540`	`+ // Protect the config of the listener socket from a data race.`
	`541`	`+ ScopedLock lck(ls->core().m_ConnectionLock);`
`540`	`542`	`ns = new CUDTSocket(*ls);`
`541`	`543`	`// No need to check the peer, this is the address from which the request has come.`
`542`	`544`	`ns->m_PeerAddr = peer;`