[core] Refax: added size cache to the group container (#2510).

ethouris · web-flow · commit 258a8583905d · 2022-11-07T15:36:25.000+01:00
diff --git a/srtcore/group.cpp b/srtcore/group.cpp
@@ -335,6 +335,7 @@ void CUDTGroup::GroupContainer::erase(CUDTGroup::gli_t it)
         }
     }
     m_List.erase(it);
+    --m_SizeCache;
 }
 
 void CUDTGroup::setOpt(SRT_SOCKOPT optName, const void* optval, int optlen)
diff --git a/srtcore/group.h b/srtcore/group.h
@@ -406,16 +406,21 @@ class CUDTGroup
     SRTSOCKET m_PeerGroupID;
     struct GroupContainer
     {
-        std::list<SocketData>        m_List;
+    private:
+        std::list<SocketData>  m_List;
+        sync::atomic<size_t>   m_SizeCache;
 
         /// This field is used only by some types of groups that need
         /// to keep track as to which link was lately used. Note that
         /// by removal of a node from the m_List container, this link
         /// must be appropriately reset.
         gli_t m_LastActiveLink;
 
+    public:
+
         GroupContainer()
-            : m_LastActiveLink(m_List.end())
+            : m_SizeCache(0)
+            , m_LastActiveLink(m_List.end())
         {
         }
 
@@ -425,13 +430,14 @@ class CUDTGroup
         gli_t        begin() { return m_List.begin(); }
         gli_t        end() { return m_List.end(); }
         bool         empty() { return m_List.empty(); }
-        void         push_back(const SocketData& data) { m_List.push_back(data); }
+        void         push_back(const SocketData& data) { m_List.push_back(data); ++m_SizeCache; }
         void         clear()
         {
             m_LastActiveLink = end();
             m_List.clear();
+            m_SizeCache = 0;
         }
-        size_t size() { return m_List.size(); }
+        size_t size() { return m_SizeCache; }
 
         void erase(gli_t it);
     };

Original file line number	Diff line number	Diff line change
`@@ -335,6 +335,7 @@ void CUDTGroup::GroupContainer::erase(CUDTGroup::gli_t it)`
`335`	`335`	`}`
`336`	`336`	`}`
`337`	`337`	`m_List.erase(it);`
	`338`	`+ --m_SizeCache;`
`338`	`339`	`}`
`339`	`340`
`340`	`341`	`void CUDTGroup::setOpt(SRT_SOCKOPT optName, const void* optval, int optlen)`