Skip to content

Comments

Add consistent Hack23 branding to all 14 language footers#90

Merged
pethers merged 6 commits intomainfrom
copilot/update-footer-with-hack23-info
Feb 11, 2026
Merged

Add consistent Hack23 branding to all 14 language footers#90
pethers merged 6 commits intomainfrom
copilot/update-footer-with-hack23-info

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

📋 Task: Address PR Review Comments ✅ COMPLETE

Changes Made:

1. Fixed Duplicate Footer in index_ja.html

  • Issue: Japanese file had two identical footers - one after </main> (line 233) and one at the end (line 511)
  • Fix: Removed the first footer that appeared after </main> to maintain proper document structure
  • Impact:
    • Fixes invalid HTML structure (content should not appear after footer)
    • Improves screen-reader navigation by eliminating duplicate landmark
    • Ensures only one footer appears at the very end of the document

2. Restored Policy Links in index.html

  • Issue: Security Policy and Privacy Policy links were removed from footer
  • Fix: Added back links to Security Policy and Privacy Policy in the "Built by Hack23 AB" footer section
  • Impact:
    • Maintains compliance visibility for key policies
    • Ensures users can easily access important legal/security documentation
    • Links now included alongside other company information

Updated Footer Structure (index.html):

<div class="footer-section">
  <h3>Built by Hack23 AB</h3>
  <p>Swedish cybersecurity consultancy specializing in political transparency and open-source intelligence.</p>
  <ul>
    <li><a href="https://www.hack23.com">Hack23.com</a></li>
    <li><a href="https://www.linkedin.com/company/hack23/">Company LinkedIn</a></li>
    <li><a href="https://github.com/Hack23/ISMS-PUBLIC">Public ISMS</a></li>
    <li><a href="...">Security Policy</a></li> <!-- ✅ RESTORED -->
    <li><a href="...">Privacy Policy</a></li> <!-- ✅ RESTORED -->
    <li><a href="mailto:[email protected]">Contact Us</a></li>
  </ul>
</div>

Validation:

  • ✅ HTML validation: No new errors introduced
  • ✅ Single footer per page (index_ja.html fixed)
  • ✅ Policy links visible and accessible
  • ✅ Proper document structure maintained

Status: ✅ All PR review comments addressed
Date: February 11, 2026


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update footer to clarify Hack23 ownership of riksdagsmonitor Add Hack23 company branding to footer Feb 11, 2026
Copilot AI requested a review from pethers February 11, 2026 13:17
Copilot AI changed the title Add Hack23 company branding to footer Add consistent Hack23 branding to all 14 language footers Feb 11, 2026
@pethers pethers requested a review from Copilot February 11, 2026 13:46
@github-actions
Copy link
Contributor

🔍 Lighthouse Performance Audit

Category Score Status
Performance 85/100 🟡
Accessibility 95/100 🟢
Best Practices 90/100 🟢
SEO 95/100 🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Standardizes Hack23 AB attribution/branding in the footer across the main page and all language-specific landing pages, replacing inconsistent/legacy footer content.

Changes:

  • Replaces varied language footer blocks with a consistent 3-line Hack23 AB branding footer (org number, location, founder/CEO, and key links).
  • Updates the main index.html footer “Resources” section to “Built by Hack23 AB” with Hack23-centric links.
  • Updates older/simpler footers (e.g., index_ja.html) to the same branding structure.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
index.html Renames a footer column to “Built by Hack23 AB”, swaps resource links for Hack23 links, and updates footer-bottom attribution formatting.
index_sv.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Swedish.
index_da.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Danish.
index_no.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Norwegian.
index_fi.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Finnish.
index_de.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in German.
index_fr.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in French.
index_es.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Spanish.
index_nl.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Dutch.
index_ar.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Arabic (RTL page).
index_he.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Hebrew (RTL page).
index_ja.html Updates two existing footers to the standardized Hack23 branding footer in Japanese.
index_ko.html Replaces legacy mixed-link footer line with standardized Hack23 branding footer in Korean.
index_zh.html Replaces a multi-column footer block with a simplified standardized Hack23 branding footer in Chinese.

index_ja.html Outdated
Comment on lines 233 to 236
<footer>
<p>&copy; 2025 Hack23 AB. All rights reserved.</p>
<p><a href="index_ja.html">ホーム</a> | <a href="blog_ja.html">ブログ</a></p>
<p>&copy; 2008-2026 <a href="https://www.hack23.com" target="_blank" rel="noopener noreferrer">Hack23 AB</a> (登録番号 5595347807) | ヨーテボリ、スウェーデン</p>
<p>創設者兼CEO: <a href="https://www.linkedin.com/in/jamessorling/" target="_blank" rel="noopener noreferrer">James Pether Sörling</a>, CISSP, CISM</p>
<p>
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index_ja.html has a <footer> inserted immediately after the initial <main>/</main>, but substantial page content continues afterward (e.g., the dashboards). This results in content appearing after a page footer and outside the main landmark, which is invalid document structure and can confuse screen-reader landmark navigation/SEO. Consider removing this first footer and keeping a single footer at the very end (or move the subsequent sections inside <main> and place one footer after all content).

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 9f3cddc. Removed the first footer that appeared after </main> in index_ja.html. The file now has a single footer at the end, maintaining proper document structure and avoiding duplicate navigation landmarks.

Comment on lines 511 to +514
<footer>
<p>&copy; 2025 Hack23 AB. All rights reserved.</p>
<p><a href="index_ja.html">ホーム</a> | <a href="blog_ja.html">ブログ</a></p>
<p>&copy; 2008-2026 <a href="https://www.hack23.com" target="_blank" rel="noopener noreferrer">Hack23 AB</a> (登録番号 5595347807) | ヨーテボリ、スウェーデン</p>
<p>創設者兼CEO: <a href="https://www.linkedin.com/in/jamessorling/" target="_blank" rel="noopener noreferrer">James Pether Sörling</a>, CISSP, CISM</p>
<p>
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two identical footers in index_ja.html (one earlier in the file and this one at the end). Duplicating global footer content can create repetitive navigation for assistive tech and complicate maintenance. Keep a single footer (preferably this final one) and remove the earlier duplicate.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 9f3cddc. Removed the duplicate footer. The file now has only one footer at the end of the document.

Comment on lines +1226 to +1231
<h3>Built by Hack23 AB</h3>
<p>Swedish cybersecurity consultancy specializing in political transparency and open-source intelligence.</p>
<ul>
<li><a href="https://github.com/Hack23/ISMS-PUBLIC" target="_blank" rel="noopener noreferrer" title="Public ISMS Repository">ISMS Documentation</a></li>
<li><a href="https://github.com/Hack23/ISMS-PUBLIC/blob/main/Information_Security_Policy.md" target="_blank" rel="noopener noreferrer" title="Information Security Policy">Security Policy</a></li>
<li><a href="https://github.com/Hack23/ISMS-PUBLIC/blob/main/Privacy_Policy.md" target="_blank" rel="noopener noreferrer" title="Privacy Policy">Privacy Policy</a></li>
<li><a href="https://www.hack23.com" target="_blank" rel="noopener noreferrer">Hack23.com</a></li>
<li><a href="https://www.linkedin.com/company/hack23/" target="_blank" rel="noopener noreferrer">Company LinkedIn</a></li>
<li><a href="https://github.com/Hack23/ISMS-PUBLIC" target="_blank" rel="noopener noreferrer">Public ISMS</a></li>
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This footer change removes links to Security Policy and Privacy Policy (previously in the “Resources” section). That’s a broader content/compliance visibility change than just “branding consistency” and may make key policies harder to find. If the intent is only to rebrand, consider keeping those policy links here (or ensure they’re still linked prominently elsewhere) and update the PR description accordingly.

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 9f3cddc. Added back the Security Policy and Privacy Policy links to the "Built by Hack23 AB" footer section in index.html. The links now appear alongside the other company information, maintaining compliance visibility.

@pethers
Copy link
Member

pethers commented Feb 11, 2026

@copilot apply changes based on the comments in this thread

@github-actions
Copy link
Contributor

🔍 Lighthouse Performance Audit

Category Score Status
Performance 85/100 🟡
Accessibility 95/100 🟢
Best Practices 90/100 🟢
SEO 95/100 🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

@pethers pethers marked this pull request as ready for review February 11, 2026 14:37
@github-actions
Copy link
Contributor

🔍 Lighthouse Performance Audit

Category Score Status
Performance 85/100 🟡
Accessibility 95/100 🟢
Best Practices 90/100 🟢
SEO 95/100 🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

@pethers pethers merged commit cf73afa into main Feb 11, 2026
11 checks passed
@pethers pethers deleted the copilot/update-footer-with-hack23-info branch February 11, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants