Skip to content

Comments

docs: fix PR #512 review feedback on workflow instruction files#514

Merged
pethers merged 3 commits intoreduceconflictsfrom
copilot/sub-pr-512
Feb 25, 2026
Merged

docs: fix PR #512 review feedback on workflow instruction files#514
pethers merged 3 commits intoreduceconflictsfrom
copilot/sub-pr-512

Conversation

Copy link
Contributor

Copilot AI commented Feb 25, 2026

Three active review comments from the PR #512 code review were unaddressed. All relate to documentation gaps in agent workflow instruction files.

Changes

  • news-weekly-review.md: Note about build-time generation was missing the local dev instruction. Added npm run prebuild guidance so agents on a fresh checkout know how to produce derived files before previewing/validating.

  • news-article-generator.md: Step 7.5 is a blocking validation gate but the preceding Step 6 gave no instruction on how to produce the artifacts being validated. Added an explicit npm run prebuild callout between Step 6 and Step 7.5.

  • news-propositions.md: Replaced a copy-pasted build-time generation paragraph (duplicated across all 10 workflow docs) with a cross-reference to the canonical guidance in news-article-generator.md, reducing future drift.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@github-actions github-actions bot added the size-xs Extra small change (< 10 lines) label Feb 25, 2026
Copilot AI changed the title [WIP] refactor: apply feedback to move derived files to build-time generation docs: fix PR #512 review feedback on workflow instruction files Feb 25, 2026
@pethers pethers marked this pull request as ready for review February 25, 2026 00:47
@pethers pethers merged commit b9665b2 into reduceconflicts Feb 25, 2026
@pethers pethers deleted the copilot/sub-pr-512 branch February 25, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-xs Extra small change (< 10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants