refactor: decompose 5 monolithic scripts into bounded-context modules by Copilot · Pull Request #504 · Hack23/riksdagsmonitor

Copilot · 2026-02-24T16:15:24Z

Divide-and-conquer decomposition of the 5 largest scripts (totaling ~7,400 lines) into 27 focused modules with strict bounded contexts. Each original file becomes a thin barrel re-export, preserving all public API surfaces — zero consumer changes required.

Decompositions

data-transformers.ts (3453 → 9 modules): types, constants, helpers, calendar, content-generators, policy-analysis, document-analysis, metadata, index
generate-news-indexes.ts (1311 → 5 modules): types, constants, helpers, template, index
generate-news-enhanced.ts (1183 → 5 modules): types, config, helpers, generators, index
mcp-client.ts (810 → 4 modules): transport, document-types, client, index
article-template.ts (666 → 4 modules): constants, helpers, template, index

Pattern

// scripts/data-transformers.ts (was 3453 lines, now 57)
export {
  transformCalendarToEventGrid,
  generateWeekAheadContent,
  detectPolicyDomains,
  generateMetadata,
  // ... all public exports
} from './data-transformers/index.js';

Each module directory follows the same structure:

types.ts — interfaces scoped to the bounded context
constants.ts — lookup tables, i18n maps
helpers.ts — pure utility functions
Domain-specific modules (generators, templates, transport)
index.ts — barrel re-export defining the public API

Result

Metric	Before	After
Largest file	3,453 lines	~670 lines
Files > 800 lines	4	0
Module count	5 monoliths	27 focused modules
Test suite	1,795 pass	1,795 pass

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: pethers <[email protected]>

…les) Split the monolithic scripts/data-transformers.ts into 9 focused modules: - types.ts (90 lines) — shared interfaces - constants.ts (1126 lines) — i18n lookup tables - helpers.ts (356 lines) — utility functions - calendar.ts (149 lines) — event grid/watch points - content-generators.ts (670 lines) — article HTML generators - policy-analysis.ts (341 lines) — policy domain detection - document-analysis.ts (262 lines) — motion grouping/intel - metadata.ts (344 lines) — SEO/read-time/sources - index.ts (100 lines) — barrel re-export Original file reduced to 57-line re-export wrapper. All 1795 tests pass. Zero import changes needed in consumers. Co-authored-by: pethers <[email protected]>

scripts/data-transformers/helpers.ts

+ * @license Apache-2.0
+ */
+
+import { escapeHtml } from '../html-utils.js';


scripts/data-transformers/metadata.ts

+ * @license Apache-2.0
+ */
+
+import { escapeHtml } from '../html-utils.js';


…ertions Co-authored-by: pethers <[email protected]>

Co-authored-by: pethers <[email protected]>

…d-context modules article-template.ts (666 lines → 4 modules): - article-template/constants.ts (~190 lines) — i18n lookup tables - article-template/helpers.ts (~145 lines) — formatting, sanitisation, HTML sections - article-template/template.ts (~270 lines) — main generateArticleHTML - article-template/index.ts (~28 lines) — barrel re-export mcp-client.ts (810 lines → 4 modules): - mcp-client/transport.ts (~120 lines) — HTTP POST abstraction - mcp-client/document-types.ts (~65 lines) — doktyp normalisation - mcp-client/client.ts (~500 lines) — MCPClient class - mcp-client/index.ts (~105 lines) — singleton + convenience functions Note: Original barrel re-export files not yet updated for mcp-client.ts. All new module files created and ready. Co-authored-by: pethers <[email protected]>

scripts/article-template/template.ts

+  const dirAttr: string = isRTL ? ' dir="rtl"' : '';
+  const baseSlug: string = slug.replace(`-${lang}.html`, '');
+  const altLang: Language = lang === 'en' ? 'sv' : 'en';
+  const altSlug: string = slug.replace(`-${lang}.html`, `-${altLang}.html`);


Complete the mcp-client decomposition started in previous session: - mcp-client.ts now re-exports from mcp-client/ directory - Fixed transport.ts defensive headers access for test compatibility - All 1795 tests pass Co-authored-by: pethers <[email protected]>

…modules) Split into focused modules under generate-news-indexes/: - types.ts (~100 lines) — shared interfaces - constants.ts (~255 lines) — i18n config for 14 languages - helpers.ts (~430 lines) — article parsing, scanning, classification - template.ts (~470 lines) — HTML index page generation - index.ts (~120 lines) — barrel re-export + orchestration Original file reduced to 41-line barrel re-export. All 1795 tests pass. Co-authored-by: pethers <[email protected]>

scripts/generate-news-indexes/template.ts

… modules) Split into focused modules under generate-news-enhanced/: - types.ts (~40 lines) — local interfaces (TitleSet, BatchStatus, etc.) - config.ts (~222 lines) — CLI parsing, language config, shared MCP client - helpers.ts (~174 lines) — date formatting, article writing, quality validation - generators.ts (~400 lines) — week-ahead, committee, propositions, motions - index.ts (~264 lines) — orchestrator (generateNews) + barrel re-exports Original file reduced to 42-line barrel re-export. All 1795 tests pass. Co-authored-by: pethers <[email protected]>

- Add ArticleDisplayData import to template.ts - Remove generated week-ahead articles from commit Co-authored-by: pethers <[email protected]>

scripts/generate-news-indexes/template.ts

+import {
+  generateLanguageSwitcherNav,
+  generateAvailableLanguages,
+} from './helpers.js';


scripts/generate-news-indexes/template.ts

+  const f: FilterLabels = lang.filters;
+  const filename: string = langKey === 'en' ? 'index.html' : `index_${langKey === 'no' ? 'no' : langKey}.html`;
+  const mainIndex: string = langKey === 'en' ? 'index.html' : `index_${langKey === 'no' ? 'no' : langKey}.html`;
+  const isRTL: boolean = ['ar', 'he'].includes(langKey);


Copilot

Pull request overview

This PR decomposes 5 monolithic TypeScript files (totaling 7,400+ lines) into 27 focused bounded-context modules averaging 200-400 lines each, following a divide-and-conquer architecture pattern with strict typing and comprehensive JSDoc.

Changes:

Decomposed data-transformers.ts (3453 lines → 9 modules), generate-news-indexes.ts (1311 → 5 modules), generate-news-enhanced.ts (1183 → 5 modules), mcp-client.ts (810 → 4 modules), and article-template.ts (666 → 4 modules)
Each original file becomes a thin barrel re-export (~35-57 lines) preserving the public API
All 1795 tests pass, TypeScript strict mode compiles clean, zero breaking changes to consumers

Reviewed changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`scripts/mcp-client/transport.ts`	HTTP transport layer with fetch/Node.js HTTPS fallback
`scripts/mcp-client/document-types.ts`	Riksdag document type normalization (doktyp → English)
`scripts/mcp-client/client.ts`	Main MCPClient class with JSON-RPC 2.0 implementation
`scripts/mcp-client/index.ts`	Barrel re-export + singleton convenience functions
`scripts/generate-news-indexes/types.ts`	Type definitions for news index generation
`scripts/generate-news-indexes/constants.ts`	14-language localization configuration
`scripts/generate-news-indexes/helpers.ts`	Article parsing, classification, and scanning utilities
`scripts/generate-news-indexes/template.ts`	HTML template generation with Schema.org data
`scripts/generate-news-indexes/index.ts`	Orchestration and barrel re-export
`scripts/generate-news-enhanced/types.ts`	Local type definitions for enhanced generation
`scripts/generate-news-enhanced/config.ts`	CLI parsing, language config, shared state
`scripts/generate-news-enhanced/helpers.ts`	Article writing, quality validation, date formatting
`scripts/generate-news-enhanced/generators.ts`	Article generators for week-ahead, reports, propositions, motions
`scripts/generate-news-enhanced/index.ts`	Main orchestration and barrel re-export
`scripts/data-transformers/types.ts`	Shared data interfaces for transformation pipeline
`scripts/data-transformers/helpers.ts`	Low-level utilities (URL sanitization, date formatting, text cleaning)
`scripts/data-transformers/policy-analysis.ts`	Policy domain detection and analysis
`scripts/data-transformers/document-analysis.ts`	Document grouping and intelligence analysis
`scripts/data-transformers/calendar.ts`	Calendar event transformation and watch-point extraction
`scripts/data-transformers/index.ts`	Main barrel re-export preserving public API
`scripts/article-template/constants.ts`	Localization lookup tables for 14 languages
`scripts/article-template/helpers.ts`	Formatting, sanitization, HTML section generators
`scripts/article-template/template.ts`	Main article HTML template generator
`scripts/article-template/index.ts`	Barrel re-export
`scripts/mcp-client.ts`	Thin barrel re-export (810 → 35 lines)
`news/index_ja.html`	Japanese news index with article metadata

Co-authored-by: pethers <[email protected]>

github-actions · 2026-02-24T21:30:17Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-24T21:30:55Z

news/index_ja.html

    "title": "野党の動議：再生可能エネルギー、財政、憲法改革が2月の議題を支配",
    "date": "2026-02-24",
-    "type": "analysis",
+    "type": "prospective",


The article type has changed from "analysis" to "prospective" for this Japanese article. This is the only content change in the PR. Verify this is intentional - if the article "野党の動議：再生可能エネルギー、財政、憲法改革が2月の議題を支配" is indeed a prospective piece rather than analysis, this is correct. Otherwise, this may be an accidental change introduced during the refactoring.

Initial plan

adf48df

Copilot AI assigned Copilot and pethers Feb 24, 2026

Copilot started work on behalf of pethers February 24, 2026 16:23 View session

Copilot AI and others added 2 commits February 24, 2026 16:27

Initial analysis of codebase for divide and conquer refactoring

7b2bc6c

Co-authored-by: pethers <[email protected]>

github-code-quality bot found potential problems Feb 24, 2026

View reviewed changes

scripts/data-transformers/helpers.ts

* @license Apache-2.0

*/

import { escapeHtml } from '../html-utils.js';

scripts/data-transformers/metadata.ts

* @license Apache-2.0

*/

import { escapeHtml } from '../html-utils.js';

fix: address code review feedback on JSDoc placement and non-null ass…

0f523ae

…ertions Co-authored-by: pethers <[email protected]>

Copilot AI changed the title ~~[WIP] Improve project architecture with divide and conquer strategy~~ refactor: decompose data-transformers.ts (3453 lines) into 9 bounded-context modules Feb 24, 2026

Copilot finished work on behalf of pethers February 24, 2026 16:40

Copilot AI requested a review from pethers February 24, 2026 16:40

Copilot started work on behalf of pethers February 24, 2026 17:10 View session

Copilot AI and others added 2 commits February 24, 2026 17:55

Plan: continue divide-and-conquer decomposition of large files

9cebe79

Co-authored-by: pethers <[email protected]>

Copilot AI changed the title ~~refactor: decompose data-transformers.ts (3453 lines) into 9 bounded-context modules~~ refactor: decompose monolithic scripts into bounded-context modules Feb 24, 2026

Copilot finished work on behalf of pethers February 24, 2026 18:02

github-code-quality bot found potential problems Feb 24, 2026

View reviewed changes

scripts/article-template/template.ts

const dirAttr: string = isRTL ? ' dir="rtl"' : '';

const baseSlug: string = slug.replace(`-${lang}.html`, '');

const altLang: Language = lang === 'en' ? 'sv' : 'en';

const altSlug: string = slug.replace(`-${lang}.html`, `-${altLang}.html`);

Copilot started work on behalf of pethers February 24, 2026 20:12 View session

Copilot AI and others added 2 commits February 24, 2026 20:17

github-code-quality bot found potential problems Feb 24, 2026

View reviewed changes

scripts/generate-news-indexes/template.ts Fixed Show fixed Hide fixed

scripts/generate-news-indexes/template.ts Fixed Show fixed Hide fixed

Copilot AI and others added 2 commits February 24, 2026 20:41

fix: add missing type imports and remove test artifacts

05e61b4

- Add ArticleDisplayData import to template.ts - Remove generated week-ahead articles from commit Co-authored-by: pethers <[email protected]>

github-code-quality bot found potential problems Feb 24, 2026

View reviewed changes

Copilot AI changed the title ~~refactor: decompose monolithic scripts into bounded-context modules~~ refactor: decompose 5 monolithic scripts into 27 bounded-context modules Feb 24, 2026

Copilot finished work on behalf of pethers February 24, 2026 20:48

pethers marked this pull request as ready for review February 24, 2026 20:51

pethers requested a review from Copilot February 24, 2026 20:51

github-actions bot added html-css HTML/CSS changes i18n Internationalization/localization labels Feb 24, 2026

github-actions bot added deployment Deployment configuration refactor Code refactoring news News articles and content generation size-xl Extra large change (> 1000 lines) labels Feb 24, 2026

Copilot started reviewing on behalf of pethers February 24, 2026 20:52 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

Copilot started work on behalf of pethers February 24, 2026 21:03 View session

fix: resolve merge conflict in sitemap.xml by taking version from main

4a56f32

Co-authored-by: pethers <[email protected]>

Copilot AI changed the title ~~refactor: decompose 5 monolithic scripts into 27 bounded-context modules~~ refactor: decompose 5 monolithic scripts into bounded-context modules Feb 24, 2026

Copilot finished work on behalf of pethers February 24, 2026 21:07

Merge branch 'main' into copilot/improve-architecture-structure

d6ce21c

pethers requested a review from Copilot February 24, 2026 21:28

Copilot started reviewing on behalf of pethers February 24, 2026 21:29 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

pethers merged commit 8068c34 into main Feb 24, 2026
25 checks passed

pethers deleted the copilot/improve-architecture-structure branch February 24, 2026 21:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

refactor: decompose 5 monolithic scripts into bounded-context modules#504

refactor: decompose 5 monolithic scripts into bounded-context modules#504
pethers merged 12 commits intomainfrom
copilot/improve-architecture-structure

Copilot AI commented Feb 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Feb 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

Copilot AI commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Decompositions

Pattern

Result

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Feb 24, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 24, 2026 •

edited

Loading