Skip to content

Comments

fix: resolve merge conflicts with main - integrate weekend articles and fix prospective keyword false positives#444

Merged
pethers merged 3 commits intonews-generation/weekly-review-2026-02-22-25732d3df5a3d00ffrom
copilot/sub-pr-433
Feb 22, 2026
Merged

fix: resolve merge conflicts with main - integrate weekend articles and fix prospective keyword false positives#444
pethers merged 3 commits intonews-generation/weekly-review-2026-02-22-25732d3df5a3d00ffrom
copilot/sub-pr-433

Conversation

Copy link
Contributor

Copilot AI commented Feb 22, 2026

Branch diverged from main after PR #436 (weekend-security-preparedness × 14 langs) was merged into main while this branch had independently generated 112 articles across 8 article types. All 17 conflicted files were generated files (indexes, metadata, sitemap).

Changes

Conflict resolution

  • Pulled 14 weekend-security-preparedness HTML files from origin/main
  • Regenerated all 14 news/index_*.html files — 585 articles, 9 article types × 14 languages
  • Regenerated data/news-articles.json — 571 articles, 50 unique slugs
  • Regenerated sitemap.xml — 639 URLs
  • Updated news/metadata/last-generation.json to reflect merged state (added weekend-analysis type)

Bug: prospective keyword false positives in generate-news-indexes.ts

The Swedish article body contained "De kommande veckorna" (common phrase), which matched the overly-generic prospective keyword kommande, misclassifying the weekend-security-preparedness article as prospective in the Swedish index while all other 13 languages showed analysis.

- 'veckan som kommer', 'kommande', 'framåtblick',    // sv
- 'ugen der kommer', 'kommende', 'fremadrettet',     // da
- 'tuleva viikko', 'tulevat', 'ennakko',             // fi
+ 'veckan som kommer', 'kommande vecka', 'framåtblick',  // sv
+ 'ugen der kommer', 'kommende uge', 'fremadrettet',     // da
+ 'tuleva viikko', 'ennakko',                            // fi

All 14 language indexes now consistently classify weekend-security-preparedness as analysis.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits February 22, 2026 18:12
…cles and regenerate all indexes

Co-authored-by: pethers <[email protected]>
…spective keywords to prevent false positives

Co-authored-by: pethers <[email protected]>
Copilot AI changed the title [WIP] Add weekly review for Feb 15-22 2026 parliamentary activity fix: resolve merge conflicts with main - integrate weekend articles and fix prospective keyword false positives Feb 22, 2026
Copilot AI requested a review from pethers February 22, 2026 18:17
@pethers pethers marked this pull request as ready for review February 22, 2026 18:22
@pethers pethers merged commit 4e7151c into news-generation/weekly-review-2026-02-22-25732d3df5a3d00f Feb 22, 2026
@pethers pethers deleted the copilot/sub-pr-433 branch February 22, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants