fix: accurate sources list and safe slug in generate-news-enhanced.ts#442
Merged
pethers merged 2 commits intonews-generation/weekly-review-2026-02-22-25732d3df5a3d00ffrom Feb 22, 2026
Conversation
…pty fallback Co-authored-by: pethers <[email protected]>
Copilot
AI
changed the title
[WIP] Update weekly review for Feb 15-22 2026 parliamentary activity
fix: accurate sources list and safe slug in generate-news-enhanced.ts
Feb 22, 2026
0d59f24
into
news-generation/weekly-review-2026-02-22-25732d3df5a3d00f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in
generate-news-enhanced.tsidentified by code review.Changes
Remove
search_anforandenfrom week-ahead sources —generateWeekAhead()never callsclient.searchSpeeches(), so the source was a false declaration. Removed to keep declared MCP tools in sync with actual calls.Guard against empty
topSlug— Titles composed entirely of non-ASCII characters (e.g. Swedish Å/Ä/Ö) produce an empty string after the ASCII-only sanitization regex, which would propagate an invalid slug into breaking-news generation. Added|| 'news'fallback:💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.