Skip to content

Comments

fix: build verification, SQL compatibility note, spelling, and MCP config syntax clarification#417

Merged
pethers merged 2 commits intostricttypingfrom
copilot/sub-pr-407-again
Feb 21, 2026
Merged

fix: build verification, SQL compatibility note, spelling, and MCP config syntax clarification#417
pethers merged 2 commits intostricttypingfrom
copilot/sub-pr-407-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 21, 2026

Addresses four issues from PR review thread #3835994755.

Changes

  • deploy-s3.yml – Added artifact verification step after npm run build to fail fast if dist/ or dist/index.html is absent, preventing a silent bad deployment:

    - name: Verify build artifacts
      run: |
        [ -d "dist" ] || { echo "❌ dist/ missing"; exit 1; }
        [ -f "dist/index.html" ] || { echo "❌ dist/index.html missing"; exit 1; }
        echo "✅ Build artifacts verified"
  • political-science-analysis/SKILL.md – Added inline comment on the QUALIFY clause noting it is only available in Snowflake, BigQuery, and DuckDB, with a hint to use a CTE + WHERE row_num = 1 for standard SQL portability.

  • seo-best-practices/SKILL.md – Fixed Swedish compound noun: Risk analysRiskanalys.

  • mcp-gateway-security/SKILL.md – Disambiguated environment variable reference syntax across contexts: ${VAR_NAME} (MCP JSON), $VAR_NAME (shell), ${{ secrets.VAR_NAME }} (GitHub Actions).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…fix, SQL note, config clarification

Co-authored-by: pethers <[email protected]>
Copilot AI changed the title [WIP] Add Evening Analysis Content Validator for intelligence assessment quality fix: build verification, SQL compatibility note, spelling, and MCP config syntax clarification Feb 21, 2026
Copilot AI requested a review from pethers February 21, 2026 21:02
@pethers pethers marked this pull request as ready for review February 21, 2026 21:02
@pethers pethers merged commit d1c88a6 into stricttyping Feb 21, 2026
@pethers pethers deleted the copilot/sub-pr-407-again branch February 21, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants