fix: generate TypeDoc before unit tests to resolve sitemap API coverage failures#416
Merged
pethers merged 2 commits intostricttypingfrom Feb 21, 2026
Merged
fix: generate TypeDoc before unit tests to resolve sitemap API coverage failures#416pethers merged 2 commits intostricttypingfrom
pethers merged 2 commits intostricttypingfrom
Conversation
… coverage tests Co-authored-by: pethers <[email protected]>
Copilot
AI
changed the title
[WIP] Add Evening Analysis Content Validator for quality assessment
fix: generate TypeDoc before unit tests to resolve sitemap API coverage failures
Feb 21, 2026
github-actions
bot
added
workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
api/directory is in.gitignoreand generated on-demand by TypeDoc. The Vitest unit tests for sitemap generation (tests/sitemap-generation.test.ts) assert that API docs are included in the sitemap, but the CI unit test job ran without ever generating them — causing 4 tests to fail consistently.Changes
.github/workflows/javascript-testing.yml: Addednpm run typedocstep between TypeScript type-checking and Vitest execution in theunit-testsjob, soapi/exists whengenerate-sitemap.tsscans the filesystem during testsThe fix is intentionally minimal — tests already correctly validate sitemap API coverage; they just needed the prerequisite artifact to exist at runtime.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.