Fix Mermaid parse error in THREAT_MODEL.md Scenario 2 attack tree#226
Merged
Fix Mermaid parse error in THREAT_MODEL.md Scenario 2 attack tree#226
Conversation
Co-authored-by: pethers <[email protected]>
Copilot
AI
changed the title
[WIP] Fix parse error in Mermaid diagram in THREAT_MODEL.md
Fix Mermaid parse error in THREAT_MODEL.md Scenario 2 attack tree
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub's Mermaid renderer failed on Scenario 2 attack tree due to unescaped double quotes in node C2 label, causing parse error:
Expecting 'SQE', 'DOUBLECIRCLEEND', 'PE'... got 'STR'.Changes
Before:
After:
Pattern: Wrap entire label in double quotes when label contains quoted text; use single quotes for inner quotations.
Validation
All 9 Mermaid diagrams (lines 202, 267, 340, 591, 682, 765, 1740, 2042, 2120) validated:
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.