Update Arabic translations for the evening analysis article, enhancing clarity and accuracy.#181
Conversation
…g clarity and accuracy.
…ity and accuracy.
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
…for clarity and accuracy
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
…emnant - Translate all Swedish h3 titles and body text to Hebrew, Japanese, Korean, Chinese - Fix og:locale metadata for each language (he_IL, ja_JP, ko_KR, zh_CN) - Translate site-tagline and section headers to target languages - Replace undefined document links with actual references - Fix remaining English 'Parliamentary Pulse' h2 in Finnish evening analysis - All 13 non-SV languages now fully translated (51+ article files total)
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
- Remove </p></p> double closing tags (20 files) - Remove <p><p> double opening tags (6 committee-reports files) - HTMLHint: 97 files scanned, 0 errors - All 900 tests pass
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
…larity and accuracy
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
…arity and accuracy
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
…article for clarity and accuracy
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
…rticle for clarity and accuracy
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
…clarity and accuracy
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Co-authored-by: pethers <[email protected]>
…and-index [WIP] Separate screenshot script changes from translation PR
Separate screenshot script changes from Arabic translation PR
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
|
@copilot remove all references for for sample html files. DO NOT want any samples, only real code !! Why was this restored ? Is it used by agentic workflows or why was it restored ? 2026-02-14-sample-no-embedded-css-en.html |
- Delete news/sample-economist-style.html - Delete news/2026-02-14-sample-no-embedded-css-en.html - Update scripts/take-screenshot.js to use real article (2026-02-13-evening-analysis-en.html) - Update NEWS_ARTICLE_STYLING_GUIDE.md to reference real examples instead of sample - Regenerate news/index.html and sitemap.xml to remove sample file entries - HTMLHint validation: 124 files, 0 errors Co-authored-by: pethers <[email protected]>
Remove sample HTML files from production codebase
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 50 out of 51 changed files in this pull request and generated 16 comments.
Comments suppressed due to low confidence (1)
scripts/take-screenshot.js:16
- The screenshot script now targets a single hard-coded dated article file. This will break as soon as that file is renamed/removed and makes the script less reusable. Consider accepting the target HTML path as a CLI arg (with a sensible default), or resolving the newest English article dynamically from news/index.html.
| "date": "2026-02-13T18:00:00.000Z", | ||
| "type": "analysis", | ||
| "type": "prospective", | ||
| "slug": "2026-02-13-evening-analysis-nl.html", |
There was a problem hiding this comment.
The evening analysis entry (slug 2026-02-13-evening-analysis-nl.html) is being reclassified from "analysis" to "prospective" here, while the English index keeps it as "analysis". This will make type filtering inconsistent across languages; please keep the type aligned (likely "analysis").
| "date": "2026-02-13T18:00:00.000Z", | ||
| "type": "analysis", | ||
| "type": "prospective", | ||
| "slug": "2026-02-13-evening-analysis-ko.html", |
There was a problem hiding this comment.
The evening analysis entry (slug 2026-02-13-evening-analysis-ko.html) is being reclassified from "analysis" to "prospective" here, while the English index keeps it as "analysis". This will make type filtering inconsistent across languages; please keep the type aligned (likely "analysis").
| "date": "2026-02-13T18:00:00.000Z", | ||
| "type": "analysis", | ||
| "type": "prospective", | ||
| "slug": "2026-02-13-evening-analysis-da.html", |
There was a problem hiding this comment.
The evening analysis entry (slug 2026-02-13-evening-analysis-da.html) is being reclassified from "analysis" to "prospective" here, while the English index keeps it as "analysis". This will make type filtering inconsistent across languages; please keep the type aligned (likely "analysis").
| "date": "2026-02-13T18:00:00.000Z", | ||
| "type": "analysis", | ||
| "type": "prospective", | ||
| "slug": "2026-02-13-evening-analysis-ar.html", |
There was a problem hiding this comment.
The evening analysis entry (slug 2026-02-13-evening-analysis-ar.html) is being reclassified from "analysis" to "prospective" here, while the English index keeps it as "analysis". This will make type filtering inconsistent across languages; please keep the type aligned (likely "analysis").
| <h3>국가 공무원 파견 조건 개선</h3> | ||
| <p><strong>위원회:</strong> SoU</p> | ||
| <p><strong>문서:</strong> <a href="https://data.riksdagen.se/dokument/HD01SoU36.html" class="document-link" rel="noopener noreferrer">undefined</a></p> | ||
| <p>의회 사안에 대한 위원회 보고서.</p> | ||
| <p><strong>문서:</strong> <a href="https://data.riksdagen.se/dokument/HD01SoU36.html" class="document-link" rel="noopener noreferrer">SoU36</a></p> | ||
| <p>국가 소속 인력의 해외 파견에 대한 조건을 개선하기 위한 위원회 보고서.</p> |
There was a problem hiding this comment.
The visible article content now has correct document labels, but the JSON-LD NewsArticle "articleBody" still contains "undefined" document link labels (visible via search for "undefined" in this file). Please regenerate/update the structured data so it matches the visible article content for SEO consistency.
| <p><strong>Author:</strong> undefined</p> | ||
| <p><strong>Party:</strong> undefined</p> | ||
| <p><strong>Document:</strong> <a href="https://data.riksdagen.se/dokument/HD023901.html" class="document-link" rel="noopener noreferrer">Mot. 2025/26:3901</a></p> |
There was a problem hiding this comment.
This page renders "Author: undefined" / "Party: undefined" for motions in the list, which is user-facing broken content. The generator should either populate these fields from data sources or omit the lines / use an explicit fallback like "Unknown" when data is missing.
| "date": "2026-02-13T18:00:00.000Z", | ||
| "type": "analysis", | ||
| "type": "prospective", | ||
| "slug": "2026-02-13-evening-analysis-ja.html", |
There was a problem hiding this comment.
The evening analysis entry (slug 2026-02-13-evening-analysis-ja.html) is being reclassified from "analysis" to "prospective" here, while the English index keeps it as "analysis". This will make type filtering inconsistent across languages; please keep the type aligned (likely "analysis").
| "date": "2026-02-13T18:00:00.000Z", | ||
| "type": "analysis", | ||
| "type": "prospective", | ||
| "slug": "2026-02-13-evening-analysis-he.html", |
There was a problem hiding this comment.
The evening analysis entry (slug 2026-02-13-evening-analysis-he.html) is being reclassified from "analysis" to "prospective" here, while the English index keeps it as "analysis". This will make type filtering inconsistent across languages; please keep the type aligned (likely "analysis").
| <h3>Vägtrafik- och fordonsfrågor</h3> | ||
| <p><strong>Kommitté:</strong> TU</p> | ||
| <p><strong>Dokument:</strong> <a href="https://data.riksdagen.se/dokument/HD01TU9.html" class="document-link" rel="noopener noreferrer">undefined</a></p> |
There was a problem hiding this comment.
Several document links in this article still render anchor text as "undefined" (e.g., the TU document link). This looks like a templating/data-mapping error and should be replaced with the actual document identifier (as other languages do, e.g., "TU9", "SoU36", etc.).
| <h3>改善国家工作人员外派条件</h3> | ||
| <p><strong>委员会:</strong> SoU</p> | ||
| <p><strong>文件:</strong> <a href="https://data.riksdagen.se/dokument/HD01SoU36.html" class="document-link" rel="noopener noreferrer">undefined</a></p> | ||
| <p><strong>文件:</strong> <a href="https://data.riksdagen.se/dokument/HD01SoU36.html" class="document-link" rel="noopener noreferrer">SoU36</a></p> | ||
| <p>关于议会事务的委员会报告。</p> |
There was a problem hiding this comment.
The visible article content now has correct document labels, but the JSON-LD NewsArticle "articleBody" still contains "undefined" document link labels (visible via search for "undefined" in this file). Please regenerate/update the structured data so it matches the visible article content for SEO consistency.
|
@copilot open a new pull request to apply changes based on the comments in this thread make sure all translations is complete/correct as well. |
…analysis in 9 non-English indices Co-authored-by: pethers <[email protected]>
…ions and fix document links in committee reports Co-authored-by: pethers <[email protected]>
Fix type classification and undefined content across multi-language news articles
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
No description provided.