Fix language parameter handling in news-article-generator workflow by Copilot · Pull Request #172 · Hack23/riksdagsmonitor

Copilot · 2026-02-14T15:19:58Z

DevOps Fix: Language Parameter Handling - Review Comments Addressed

Changes Made

1. ✅ Fixed Preset Expansion with Whitespace (Comment 2807597523)

File: scripts/generate-news-enhanced.js

Issue: Preset expansion checked LANGUAGE_PRESETS[languagesInput] before trimming, so "nordic " (with trailing space) wouldn't match
Fix: Added .trim().toLowerCase() before preset lookup on line 50
Result: Now handles "nordic ", " NORDIC ", "Nordic" correctly

2. ✅ Fixed Bash Case Statement Matching (Comment 2807597529)

File: .github/workflows/news-article-generator.md

Issue: Languages preset case statement used raw LANGUAGES_INPUT without trimming
Fix: Added LANGUAGES_INPUT=$(echo "$LANGUAGES_INPUT" | xargs) before case statement (line 280)
Result: Presets now match even with leading/trailing whitespace

3. ✅ Added Validation Gate (Comment 2807597531)

File: .github/workflows/news-article-generator.md

Issue: Language validation printed errors but never failed the run
Fix: Added tracking of missing languages and exit 1 when any are missing (lines 521-535)
Result: Workflow now fails fast if requested languages aren't generated

# Track any languages that are missing articles
missing_langs=()

# ... validation loop ...

# Fail the workflow if any requested languages are missing articles
if [ "${#missing_langs[@]}" -ne 0 ]; then
  echo "❌ Validation failed: No articles generated for: ${missing_langs[*]}"
  exit 1
else
  echo "✅ Validation passed: Articles generated for all requested languages."
fi

4. ✅ Fixed File Existence Check (Comment 2807597535)

File: docs/LANGUAGE_OPTIONS_TESTING.md

Issue: news/$(ls -t news/*-${lang}.html ...) produced news/news/... path
Fix: Simplified to ls -t news/*-"$lang".html 1>/dev/null 2>&1 (line 262)
Result: RTL attribute check now works correctly

5. ✅ Bonus: Fixed Same Issues in Backport Script

File: scripts/generate-news-backport.js

Applied same whitespace handling fixes
Ensures consistency across all news generation scripts

Testing Results

Test 1: Preset with Trailing Space

node scripts/generate-news-enhanced.js --languages="nordic " --dry-run
# ✅ Output: Languages: en, sv, da, no, fi

Test 2: Preset with Spaces and Uppercase

node scripts/generate-news-enhanced.js --languages=" NORDIC " --dry-run
# ✅ Output: Languages: en, sv, da, no, fi

Test 3: Validation Gate

The validation now tracks missing languages and exits with error code 1, preventing incomplete article generation from being accepted.

Files Changed

File	Changes	Lines
`scripts/generate-news-enhanced.js`	Trim+lowercase before preset lookup	50
`scripts/generate-news-backport.js`	Same fix for consistency	57-61
`.github/workflows/news-article-generator.md`	Trim input + validation gate	280, 521-535
`docs/LANGUAGE_OPTIONS_TESTING.md`	Fix file existence check	262

Next Steps

All review comments addressed. Ready for re-review and merge.

Commit: Applying all 4 PR review comments

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pethers <[email protected]>

github-actions · 2026-02-14T15:36:06Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Improves multi-language generation reliability for the news article generator by fixing whitespace handling in CLI parsing and updating the agent workflow instructions/docs to consistently invoke the existing generation script with expanded language presets.

Changes:

Trim whitespace when parsing --types and --languages in scripts/generate-news-enhanced.js.
Update .github/workflows/news-article-generator.md agent instructions to expand language presets and run generate-news-enhanced.js, plus add a language coverage validation step.
Add a comprehensive manual testing guide for language options under docs/.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
scripts/generate-news-enhanced.js	Trims CLI inputs for article types and languages to correctly handle lists like `"no, da, fi"`.
.github/workflows/news-article-generator.md	Adds explicit bash examples for expanding presets and calling the generation script, plus language coverage validation guidance.
docs/LANGUAGE_OPTIONS_TESTING.md	Adds a manual test/validation playbook for language presets, whitespace edge cases, and RTL verification.

Copilot · 2026-02-14T15:39:16Z

scripts/generate-news-enhanced.js

 }

-const languages = languagesInput.split(',').filter(l => ALL_LANGUAGES.includes(l.trim()));
+const languages = languagesInput.split(',').map(l => l.trim()).filter(l => ALL_LANGUAGES.includes(l));


The preset expansion checks LANGUAGE_PRESETS[languagesInput] before trimming, so inputs like --languages="nordic " (or newline/space from workflow inputs) won’t expand and will later be filtered to zero valid languages. Normalize languagesInput (trim and ideally lowercase) before the preset lookup so whitespace doesn’t break presets.

Fixed in 047eb4c. Added .trim().toLowerCase() to normalize languagesInput before preset lookup. Now handles "nordic ", " NORDIC ", and mixed case correctly.

Copilot · 2026-02-14T15:39:17Z

.github/workflows/news-article-generator.md

+LANGUAGES_INPUT="${{ github.event.inputs.languages }}"
+if [ -z "$LANGUAGES_INPUT" ]; then
+  LANGUAGES_INPUT="en,sv"
+fi
+
+# Expand language presets
+case "$LANGUAGES_INPUT" in
+  "nordic")
+    LANG_ARG="en,sv,da,no,fi"
+    echo "🌍 Expanding 'nordic' to: $LANG_ARG"
+    ;;
+  "eu-core")


The languages preset case statement uses the raw LANGUAGES_INPUT. If the input contains leading/trailing whitespace, presets like nordic/eu-core won’t match and the script may fail later. Trim/normalize LANGUAGES_INPUT before the case so preset handling is robust.

Fixed in 047eb4c. Added LANGUAGES_INPUT=$(echo "$LANGUAGES_INPUT" | xargs) before the case statement to trim whitespace. Presets now match reliably.

Copilot · 2026-02-14T15:39:17Z

.github/workflows/news-article-generator.md

+for lang in "${LANG_ARRAY[@]}"; do
+  lang_trimmed=$(echo "$lang" | xargs)  # Trim whitespace
+
+  # Count articles for this language
+  count=$(find news -name "*-${lang_trimmed}.html" -type f -mmin -10 | wc -l)
+
+  if [ $count -gt 0 ]; then
+    echo "  ✅ $lang_trimmed: $count articles generated"
+  else
+    echo "  ❌ $lang_trimmed: No articles found (expected at least 1)"
+  fi
+done
+


This validation loop prints an error when a requested language has no generated articles, but it never fails the run. If this is meant to be a real validation gate, track missing languages and exit 1 when any are missing so the agent/workflow can’t proceed with partial output.

Suggested change

for lang in "${LANG_ARRAY[@]}"; do

lang_trimmed=$(echo "$lang" | xargs) # Trim whitespace

# Count articles for this language

count=$(find news -name "*-${lang_trimmed}.html" -type f -mmin -10 | wc -l)

if [ $count -gt 0 ]; then

echo " ✅ $lang_trimmed: $count articles generated"

else

echo " ❌ $lang_trimmed: No articles found (expected at least 1)"

fi

done

# Track any languages that are missing articles

missing_langs=()

for lang in "${LANG_ARRAY[@]}"; do

lang_trimmed=$(echo "$lang" | xargs) # Trim whitespace

# Count articles for this language

count=$(find news -name "*-${lang_trimmed}.html" -type f -mmin -10 | wc -l)

if [ "$count" -gt 0 ]; then

echo " ✅ $lang_trimmed: $count articles generated"

else

echo " ❌ $lang_trimmed: No articles found (expected at least 1)"

missing_langs+=("$lang_trimmed")

fi

done

# Fail the workflow if any requested languages are missing articles

if [ "${#missing_langs[@]}" -ne 0 ]; then

echo "❌ Validation failed: No articles generated for the following requested languages: ${missing_langs[*]}"

exit 1

else

echo "✅ Validation passed: Articles generated for all requested languages."

fi

Fixed in 047eb4c. Implemented suggestion exactly as provided - now tracks missing_langs array and exits with exit 1 when any requested languages have zero articles. This creates a proper validation gate.

Copilot · 2026-02-14T15:39:17Z

docs/LANGUAGE_OPTIONS_TESTING.md

+  if [ -f "news/$(ls -t news/*-${lang}.html 2>/dev/null | head -1)" ]; then
+    if grep -q 'dir="rtl"' "news/"*-${lang}.html; then


The file existence check is incorrect: ls -t news/*-${lang}.html already returns paths that include news/, so wrapping it with news/$(...) produces news/news/... and the -f test will fail even when files exist. Remove the extra news/ prefix or restructure the existence check.

Suggested change

if [ -f "news/$(ls -t news/*-${lang}.html 2>/dev/null | head -1)" ]; then

if grep -q 'dir="rtl"' "news/"*-${lang}.html; then

if ls -t news/*-"$lang".html 1>/dev/null 2>&1; then

if grep -q 'dir="rtl"' news/*-"$lang".html; then

Fixed in 047eb4c. Simplified to ls -t news/*-"$lang".html 1>/dev/null 2>&1 to avoid the double news/ prefix. File existence check now works correctly.

pethers · 2026-02-14T15:49:41Z

@copilot apply changes based on the comments in this thread

Co-authored-by: pethers <[email protected]>

Copilot · 2026-02-14T15:54:07Z

@copilot apply changes based on the comments in this thread

All 4 review comments addressed in commit 047eb4c:

✅ Normalized input before preset expansion (scripts)
✅ Trimmed input before case statement (workflow)
✅ Added validation gate with exit 1 on missing languages
✅ Fixed file existence check path construction

Bonus: Also fixed same issues in generate-news-backport.js for consistency.

github-actions · 2026-02-14T16:45:41Z

🔍 Lighthouse Performance Audit

Category	Score	Status
Performance	85/100	🟡
Accessibility	95/100	🟢
Best Practices	90/100	🟢
SEO	95/100	🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Initial plan

3f8d619

Copilot AI assigned Copilot and pethers Feb 14, 2026

Copilot started work on behalf of pethers February 14, 2026 15:20 View session

Copilot AI and others added 2 commits February 14, 2026 15:27

fix: Language parameter handling in news-article-generator workflow

601672b

Co-authored-by: pethers <[email protected]>

docs: Add comprehensive language options testing guide

901a874

Co-authored-by: pethers <[email protected]>

Copilot AI changed the title ~~[WIP] Analyze language options in workflows and code~~ Fix language parameter handling in news-article-generator workflow Feb 14, 2026

Copilot AI requested a review from pethers February 14, 2026 15:31

Copilot finished work on behalf of pethers February 14, 2026 15:31

Merge branch 'main' into copilot/analyze-language-options-usage

36757f4

pethers requested a review from Copilot February 14, 2026 15:35

Copilot started reviewing on behalf of pethers February 14, 2026 15:35 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

Copilot started work on behalf of pethers February 14, 2026 15:50 View session

fix: Apply PR review comments - normalize inputs and add validation gate

047eb4c

Co-authored-by: pethers <[email protected]>

Copilot finished work on behalf of pethers February 14, 2026 15:54

pethers requested a review from Copilot February 14, 2026 16:45

Copilot started reviewing on behalf of pethers February 14, 2026 16:45 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

pethers marked this pull request as ready for review February 14, 2026 16:51

pethers approved these changes Feb 14, 2026

View reviewed changes

pethers merged commit 6caaa4d into main Feb 14, 2026
21 checks passed

pethers deleted the copilot/analyze-language-options-usage branch February 14, 2026 16:52

		if [ -f "news/$(ls -t news/*-${lang}.html 2>/dev/null \| head -1)" ]; then
		if grep -q 'dir="rtl"' "news/"*-${lang}.html; then

Comments

Conversation

Copilot AI commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DevOps Fix: Language Parameter Handling - Review Comments Addressed

Changes Made

1. ✅ Fixed Preset Expansion with Whitespace (Comment 2807597523)

2. ✅ Fixed Bash Case Statement Matching (Comment 2807597529)

3. ✅ Added Validation Gate (Comment 2807597531)

4. ✅ Fixed File Existence Check (Comment 2807597535)

5. ✅ Bonus: Fixed Same Issues in Backport Script

Testing Results

Test 1: Preset with Trailing Space

Test 2: Preset with Spaces and Uppercase

Test 3: Validation Gate

Files Changed

Next Steps

Uh oh!

github-actions bot commented Feb 14, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

pethers commented Feb 14, 2026

Uh oh!

Copilot AI commented Feb 14, 2026

Uh oh!

github-actions bot commented Feb 14, 2026

🔍 Lighthouse Performance Audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 14, 2026 •

edited

Loading