Skip to content

Comments

Enhance sitemap pages: SEO metadata, JSON-LD schemas, and quick navigation#113

Merged
pethers merged 6 commits intomainfrom
copilot/update-sitemap-for-all-languages
Feb 12, 2026
Merged

Enhance sitemap pages: SEO metadata, JSON-LD schemas, and quick navigation#113
pethers merged 6 commits intomainfrom
copilot/update-sitemap-for-all-languages

Conversation

Copy link
Contributor

Copilot AI commented Feb 11, 2026

🔧 PR Review Fixes - All Issues Resolved

Fixed all 54 issues identified in the PR review.

Issues Fixed

1. Empty Section IDs (42 issues across all files) ✅

  • Problem: Sections had id="" or missing IDs, breaking quick navigation
  • Solution: Added proper IDs matching TOC anchors for all 6 sections:
    • id="main-platform" - Main platform section
    • id="dashboards" - Interactive dashboards
    • id="news" - News & analysis
    • id="languages" - Multi-language access
    • id="resources" - Additional resources
    • id="sitemap-languages" - Sitemap language switcher
  • Verification: All 14 files now have 6 unique section IDs each

2. Incorrect og:locale (13 issues) ✅

  • Problem: Localized sitemaps had og:locale="en_US" instead of correct locale
  • Solution: Updated each file with proper locale:
    • Swedish: sv_SE
    • Danish: da_DK
    • Norwegian: nb_NO
    • Finnish: fi_FI
    • German: de_DE
    • French: fr_FR
    • Spanish: es_ES
    • Dutch: nl_NL
    • Arabic: ar_SA
    • Hebrew: he_IL
    • Japanese: ja_JP
    • Korean: ko_KR
    • Chinese: zh_CN

3. Incorrect JSON-LD SiteNavigationElement (13 issues) ✅

  • Problem: Hardcoded url="sitemap.html" and inLanguage="en" in localized pages
  • Solution: Updated to match each page:
    • url: Points to correct file (e.g., sitemap_sv.html)
    • inLanguage: Matches page language (e.g., "sv", "nb", "ar")

4. Missing Favicon (1 issue) ✅

  • Problem: Referenced /favicon.ico which doesn't exist
  • Solution: Updated to point to existing logo:
    <link rel="icon" type="image/png" href="https://cia.sourceforge.io/cia-logo.png">

5. Inconsistent Norwegian Language Code (1 issue) ✅

  • Problem: Mixed use of "no" and "nb" for Norwegian hreflang
  • Solution:
    • Updated scripts/generate-sitemap.js to use "nb" consistently
    • Maps lang="nb" to index_no.html filename
    • Regenerated sitemap.xml with correct hreflang="nb"

✅ Validation Results

HTML Validation

✅ Scanned 14 files, no errors found (48 ms)

Section IDs Verification

All 14 files have exactly 6 unique section IDs:

  • sitemap.html: 6 IDs ✅
  • sitemap_sv.html: 6 IDs ✅
  • sitemap_da.html: 6 IDs ✅
  • sitemap_no.html: 6 IDs ✅
  • sitemap_fi.html: 6 IDs ✅
  • sitemap_de.html: 6 IDs ✅
  • sitemap_fr.html: 6 IDs ✅
  • sitemap_es.html: 6 IDs ✅
  • sitemap_nl.html: 6 IDs ✅
  • sitemap_ar.html: 6 IDs ✅
  • sitemap_he.html: 6 IDs ✅
  • sitemap_ja.html: 6 IDs ✅
  • sitemap_ko.html: 6 IDs ✅
  • sitemap_zh.html: 6 IDs ✅

Norwegian Hreflang Consistency

hreflang="no": 0 occurrences ✅
hreflang="nb": 3 occurrences ✅ (index, news, sitemap)

📝 Changes Made

Files Modified

  • All 14 sitemap HTML pages: Fixed IDs, og:locale, JSON-LD, favicon
  • scripts/generate-sitemap.js: Updated LANGUAGES array to use "nb"
  • sitemap.xml: Regenerated with consistent Norwegian hreflang

Key Improvements

  1. Quick Navigation Now Works: All TOC anchor links now properly jump to sections
  2. SEO Improvements: Correct og:locale and JSON-LD for all language versions
  3. No Missing Resources: Favicon points to existing logo
  4. Consistent Language Codes: Norwegian uses "nb" throughout (HTML lang, hreflang, JSON-LD)
  5. Zero HTML Errors: All files pass HTMLHint validation

🧪 Testing Performed

  • ✅ HTML validation (all 14 files pass)
  • ✅ Section ID uniqueness verified
  • ✅ TOC anchor links match section IDs
  • ✅ og:locale correctness for all languages
  • ✅ JSON-LD URL and inLanguage match page
  • ✅ Favicon resource exists
  • ✅ Norwegian hreflang consistency in sitemap.xml
  • ✅ No empty id="" attributes remain

📊 Summary

Issue Category Files Affected Status
Empty/missing section IDs 14 ✅ Fixed
Incorrect og:locale 13 ✅ Fixed
Incorrect JSON-LD 13 ✅ Fixed
Missing favicon 14 ✅ Fixed
Norwegian hreflang 2 ✅ Fixed

Total Issues Resolved: 54/54 ✅

All PR review comments have been addressed. Quick navigation, SEO metadata, and language consistency are now fully functional across all 14 sitemap pages.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update sitemap.xml and create sitemap.html for all languages Add comprehensive multi-language sitemap coverage (14 languages, 58 URLs) Feb 11, 2026
Copilot AI requested a review from pethers February 11, 2026 23:53
@github-actions
Copy link
Contributor

🔍 Lighthouse Performance Audit

Category Score Status
Performance 85/100 🟡
Accessibility 95/100 🟢
Best Practices 90/100 🟢
SEO 95/100 🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copilot AI changed the title Add comprehensive multi-language sitemap coverage (14 languages, 58 URLs) Enhance sitemap pages: SEO metadata, JSON-LD schemas, and quick navigation Feb 12, 2026
@github-actions
Copy link
Contributor

🔍 Lighthouse Performance Audit

Category Score Status
Performance 85/100 🟡
Accessibility 95/100 🟢
Best Practices 90/100 🟢
SEO 95/100 🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the site’s sitemap experience by adding richer SEO/social metadata, JSON-LD structured data, and a “quick navigation” table-of-contents across the 14 sitemap HTML pages, and updates sitemap.xml generation to include the new pages and additional URLs.

Changes:

  • Added Open Graph/Twitter meta tags and JSON-LD structured data to sitemap HTML pages.
  • Introduced a quick-jump TOC to navigate between major sitemap sections.
  • Updated sitemap.xml and the generator script to include dashboard/sitemap URLs and alternates.

Reviewed changes

Copilot reviewed 16 out of 19 changed files in this pull request and generated 54 comments.

Show a summary per file
File Description
sitemap.html Enhanced English sitemap page with metadata, JSON-LD, TOC, and expanded link coverage.
sitemap_sv.html Swedish sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_da.html Danish sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_no.html Norwegian (Bokmål) sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_fi.html Finnish sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_de.html German sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_fr.html French sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_es.html Spanish sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_nl.html Dutch sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_ar.html Arabic (RTL) sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_he.html Hebrew (RTL) sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_ja.html Japanese sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_ko.html Korean sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap_zh.html Chinese sitemap page enhancement with metadata/JSON-LD/TOC.
sitemap.xml Updated generated sitemap entries/lastmod and added URLs for dashboards and sitemap pages.
scripts/generate-sitemap.js Extended generation logic to include politician dashboard, dashboards, and sitemap HTML pages (with alternates).

sitemap_fr.html Outdated
Comment on lines 262 to 263
<section class="sitemap-section" id="">
<h2>Plateforme principale</h2>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TOC links to #main-platform, but this section has id="". Because multiple sections in this file have empty ids, quick navigation links won’t work. Assign unique ids matching the TOC anchors (main-platform, dashboards, news, languages, resources, sitemap-languages).

Copilot uses AI. Check for mistakes.
sitemap_es.html Outdated
Comment on lines 262 to 263
<section class="sitemap-section" id="">
<h2>Plataforma principal</h2>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TOC links to #main-platform, but this section has id="". Add unique ids to sections that match the TOC anchors so quick navigation works.

Copilot uses AI. Check for mistakes.
sitemap_fi.html Outdated
Comment on lines 262 to 263
<section class="sitemap-section" id="">
<h2>Pääalusta</h2>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TOC links to #main-platform, but this section has id="". Assign unique ids matching the TOC anchors so quick navigation works (and avoid empty ids).

Copilot uses AI. Check for mistakes.
sitemap_ja.html Outdated
Comment on lines 262 to 263
<section class="sitemap-section" id="">
<h2>メインプラットフォーム</h2>
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TOC links to #main-platform, but this section has id="". Assign unique ids matching the TOC anchors so quick navigation works.

Copilot uses AI. Check for mistakes.
sitemap.html Outdated
<!-- Additional Meta Tags -->
<meta name="theme-color" content="#0a0e27">
<meta name="color-scheme" content="dark light">
<link rel="icon" type="image/png" href="/favicon.ico">
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These pages add a favicon reference to /favicon.ico, but there is no favicon.ico at the repository root. Either add the favicon asset at that path or update the link to point to an existing icon file so browsers don’t request a missing resource.

Suggested change
<link rel="icon" type="image/png" href="/favicon.ico">
<link rel="icon" type="image/png" href="https://cia.sourceforge.io/cia-logo.png">

Copilot uses AI. Check for mistakes.
sitemap_zh.html Outdated
</section>

<!-- Other Sitemap Languages -->
<section class="sitemap-section" id="">
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of the id attribute must contain at least one character.

Copilot uses AI. Check for mistakes.
sitemap_zh.html Outdated
</section>

<!-- Additional Resources -->
<section class="sitemap-section" id="">
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of the id attribute must contain at least one character.

Copilot uses AI. Check for mistakes.
sitemap_zh.html Outdated
</section>

<!-- Multi-Language Section -->
<section class="sitemap-section" id="">
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of the id attribute must contain at least one character.

Copilot uses AI. Check for mistakes.
sitemap_zh.html Outdated
</section>

<!-- News Section -->
<section class="sitemap-section" id="">
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of the id attribute must contain at least one character.

Copilot uses AI. Check for mistakes.
sitemap_zh.html Outdated
</section>

<!-- Dashboards Section -->
<section class="sitemap-section" id="">
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of the id attribute must contain at least one character.

Copilot uses AI. Check for mistakes.
@pethers
Copy link
Member

pethers commented Feb 12, 2026

@copilot apply changes based on the comments in this thread

@github-actions
Copy link
Contributor

🔍 Lighthouse Performance Audit

Category Score Status
Performance 85/100 🟡
Accessibility 95/100 🟢
Best Practices 90/100 🟢
SEO 95/100 🟢

📥 Download full Lighthouse report

Budget Compliance: Performance budgets enforced via budget.json

Copy link
Contributor Author

Copilot AI commented Feb 12, 2026

@copilot apply changes based on the comments in this thread

Fixed all 54 issues from the PR review in commit ed0654c:

Section IDs (42 issues): Added proper IDs (main-platform, dashboards, news, languages, resources, sitemap-languages) to all sections across 14 files - quick navigation now works
og:locale (13 issues): Updated to correct locale for each language (sv_SE, da_DK, nb_NO, etc.)
JSON-LD (13 issues): Fixed url and inLanguage to match each page
Favicon (1 issue): Updated to point to existing logo at https://cia.sourceforge.io/cia-logo.png
Norwegian hreflang (1 issue): Standardized on "nb" throughout (updated LANGUAGES array, regenerated sitemap.xml)

All files pass HTMLHint validation with zero errors.

Copilot AI requested a review from pethers February 12, 2026 00:38
@pethers pethers marked this pull request as ready for review February 12, 2026 00:43
@pethers pethers merged commit 71fe3fe into main Feb 12, 2026
14 checks passed
@pethers pethers deleted the copilot/update-sitemap-for-all-languages branch February 12, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants