Repository navigation
Translate 2025 Third Parties chapter to Turkish - #4556
Conversation
Makes progress on #1044
tunetheweb
left a comment
tunetheweb
left a comment
There was a problem hiding this comment.
Thanks for the translation and the corrections!
The 2024 links carry hreflang="en" because there is no tr/2024 chapter, so they redirect to English.
This is a tricky one. While this is technically correct, it does require remembering to update this is in the future if we ever add it. So until not we're not done this under the not-very-convincing thought that it links to the Turkish version, it just doesn't exist yet and is redirected to the English version in the meantime.
In the English line 176 the label says "non-USP Standard", but the text means a non-standard USP. The Turkish uses the latter. I can fix the English label in this PR too if you'd like.
Not an expert on English grammar (and certainly not on USP) but as a native speaker I think either works in English to be honest. It's still checking the us_privacy parameter (which is the USP Standard with a capital S). "non-standard USP Standard" as given in the text itself is probably most accurate, if a bit of a mouthful. Anyway happy to go with what you have here.
The description has no apostrophe on purpose. An apostrophe ends up double-escaped as ’ in the meta, og, twitter and JSON-LD tags, as can be seen live on it/2022/css.
To me that's a failure of the receiving client and they should be HTML encoded. But sometimes it's not worth the fight! :-)
Anyway, happy to merge this and will do so tomorrow unless you have any further comments on the above?
|
Thanks for the review and the context! No further comments from my side, happy for it to be merged :) |
Makes progress on #1044
This is the first Turkish chapter in the repo, so it is also the first time
src/templates/tr/base_chapter.htmlgets rendered.Changes:
src/content/tr/2025/third-parties.md: Turkish translation of the 2025 Third Parties chapter.src/templates/tr/base_chapter.html:’ınoutside the string, which Jinja rejects withTemplateSyntaxError: unexpected char '&'. Behind that,+ yearapplied a unary plus to a string, which raisesTypeError. Without the fix the chapter page would return a 500. The line now follows the English template.','instead of'.', and both are reworded.src/templates/tr/base.html:src/config/contributors.json: translator entry for MuslumYilmaz, placed alphabetically by first name.Notes:
%90puts the percent sign first, which is the Turkish convention.hreflang="en"because there is no tr/2024 chapter, so they redirect to English.’in the meta, og, twitter and JSON-LD tags, as can be seen live on it/2022/css.