You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I am developing a simple widget toolkit (working copy here) and plan on using libraqm to help with the text rendering, but the FriBiDi dependency worries me a little.
Anything using LGPL code must be released in a way that allows re-linking it with a modified version, and I try my best to write software everyone can use without limitations other than some form of attribution, which is possible under the Apache, MIT and BSD licenses, but not with the GPL or the LGPL.
If my understanding is correct, you guys (or at least @khaledhosny) know about SheenBiDi, which is Apache-licensed and could replace FriBiDi. Do you plan on supporting it? If yes, when will that happen? If not, would it be reasonable for me to fork libraqm?
Thank you for your work on this library :)
EDIT:
It looks like I'm not the first one to bring this up: Tehreer/SheenBidi#10
Ok, I'll give it a shot and see what I can help with. Quite a few boring steps will have to be taken though:
it would probably be better if SheenBidi supported Meson
(it is not a very widespread package among distros so being able to rely on Meson to build it automatically would be nice)
we should add options to choose between FriBiDi/SheenBidi and whether or not to generate a static binary
(which is fine when not using LGPL'd dependencies)
Meson support in SheenBidi would be nice of course, and an option to switch between bidi libraries. I don’t get the point about static binaries, as we don’t statically link to any of our dependencies by default.
Meson support in SheenBidi would be nice of course, and an option to switch between bidi libraries
Ok, thanks! SheenBidi's maintainer already started working on Meson support (Tehreer/SheenBidi#12)
I don’t get the point about static binaries, as we don’t statically link to any of our dependencies by default
Actually my point was that we currently build libraqm.so but not libraqm.a. Since we can't always statically link FriBiDi in our apps (because of the LGPL) it kind of made sense to just dynamically link everything so far. If however we make libraqm use SheenBidi then apps can statically link everything and it would be helpful to also generate libraqm.a. Am I missing something?
Hi, after experimenting for a while I still can't get all the tests to pass. It is probably my fault since I don't know a lot on the subject but I'd like to rule out the possibility of SheenBidi not being able to handle all libraqm test cases: is such a thing possible at all? Actually this comes to my mind because of the results of the Tehreer stack in the text rendering tests conducted by unicode. Most errors here seem to be stemming from the shaping phase but after all maybe Bidi can be faulty, too. Is it something that could cause 28 tests to fail in libraqm?
Also, I won't have as much free time to invest in this task starting from next week so I am probably going to try integrating ualyze instead to see what results I can get and draw some conclusions more easily. If it magically turns out ok, would you be interested in supporting this instead of SheenBidi?
I know that at least a couple if tests are wrong since they test newline characters but ram input should be a single paragraph, so send PR and we can assess the failures.
I can't really open a PR now as I only have a very dirty prototype with hardcoded SheenBidi support, but I can make a clean branch if you think it's ok to already move forward. Should I just ifdef the Fribidi & SheenBidi parts or do you prefer a multi-file approach?
It turns out adding utf16 support (needed by ualyze) requires making lots of other changes I am not very comfortable with so this is another dead end for me. I will stop here and clean what I have so far for SheenBidi to open a PR. Just tell me if you prefer ifdefs or one extra source file per Bidi library to separate the different versions of the functions affected by this change.
Activity
khaledhosny commentedon Oct 8, 2021
I’m open to supporting SheenBiDi as alternative to FriBiDi, but I don't have time to do it myself currently, but I’ll try to review any PRs.
nullgemm commentedon Oct 8, 2021
Ok, I'll give it a shot and see what I can help with. Quite a few boring steps will have to be taken though:
(it is not a very widespread package among distros so being able to rely on Meson to build it automatically would be nice)
(which is fine when not using LGPL'd dependencies)
Does it look acceptable to you?
khaledhosny commentedon Oct 8, 2021
Meson support in SheenBidi would be nice of course, and an option to switch between bidi libraries. I don’t get the point about static binaries, as we don’t statically link to any of our dependencies by default.
nullgemm commentedon Oct 8, 2021
Ok, thanks! SheenBidi's maintainer already started working on Meson support (Tehreer/SheenBidi#12)
Actually my point was that we currently build
libraqm.sobut notlibraqm.a. Since we can't always statically link FriBiDi in our apps (because of the LGPL) it kind of made sense to just dynamically link everything so far. If however we make libraqm use SheenBidi then apps can statically link everything and it would be helpful to also generatelibraqm.a. Am I missing something?khaledhosny commentedon Oct 8, 2021
That is a standard meson feature, by default it builds only shared libraries, but you can control it with
--default-libraryoption.nullgemm commentedon Oct 9, 2021
Oh, right. I guess everything's clear then :)
nullgemm commentedon Oct 14, 2021
Hi, after experimenting for a while I still can't get all the tests to pass. It is probably my fault since I don't know a lot on the subject but I'd like to rule out the possibility of SheenBidi not being able to handle all libraqm test cases: is such a thing possible at all? Actually this comes to my mind because of the results of the Tehreer stack in the text rendering tests conducted by unicode. Most errors here seem to be stemming from the shaping phase but after all maybe Bidi can be faulty, too. Is it something that could cause 28 tests to fail in libraqm?
Also, I won't have as much free time to invest in this task starting from next week so I am probably going to try integrating ualyze instead to see what results I can get and draw some conclusions more easily. If it magically turns out ok, would you be interested in supporting this instead of SheenBidi?
Thanks for your patience :)
khaledhosny commentedon Oct 14, 2021
I know that at least a couple if tests are wrong since they test newline characters but ram input should be a single paragraph, so send PR and we can assess the failures.
nullgemm commentedon Oct 14, 2021
I can't really open a PR now as I only have a very dirty prototype with hardcoded SheenBidi support, but I can make a clean branch if you think it's ok to already move forward. Should I just
ifdefthe Fribidi & SheenBidi parts or do you prefer a multi-file approach?nullgemm commentedon Oct 14, 2021
It turns out adding utf16 support (needed by ualyze) requires making lots of other changes I am not very comfortable with so this is another dead end for me. I will stop here and clean what I have so far for SheenBidi to open a PR. Just tell me if you prefer
ifdefsor one extra source file per Bidi library to separate the different versions of the functions affected by this change.khaledhosny commentedon Oct 14, 2021
#ifdef’s are fine if they are localized enough.khaledhosny commentedon Oct 23, 2021
Done in #139