Repository navigation
fix(tools): report partial registry construction - #1129
Conversation
Signed-off-by: er-s-an <[email protected]>
The aggregate line reports how many tool sources failed; only the per-module record says which one. Logging it at DEBUG leaves an operator in front of the same silent partial registry HKUDS#1124 is about, so it stays at WARNING and a guard test pins the level.
|
Merged — thank you. The shape was right where it counts: keeping the I pushed one commit to your branch before merging, so you are not surprised by it: the per-module discovery failure is back at WARNING rather than DEBUG. The aggregate line reports how many sources failed; only the per-module record says which, and #1124 is precisely about an operator not being able to see that. A guard test now pins the level, and I checked it bites — restoring DEBUG fails it. |
Summary
ToolRegistryRoot cause
Tool discovery logged and discarded import failures. Callers received an apparently healthy partial registry, and later requests only saw a generic
Tool not founderror.Validation
PYTHONPATH=agent python3 -m pytest agent/tests/test_tool_registry_diagnostics.py agent/tests/test_tool_registry_security.py -q— 4 passedruff check --ignore E402 agent/src/agent/tools.py agent/src/tools/__init__.py agent/tests/test_tool_registry_diagnostics.pypython3 -m compileall -q agent/src/agent/tools.py agent/src/tools/__init__.py agent/tests/test_tool_registry_diagnostics.pyThe broader MCP regression module was not fully runnable in the local system Python because
fastmcpand the optional web-search dependency are not installed.Fixes #1124