[codex] fix mastery choice persistence and grading#604
Merged
pancacake merged 1 commit intoJun 30, 2026
Conversation
Collaborator
|
Thanks for your contribution! btw, try to submit pr towards dev branch instead of main next time :) |
vaskoyudha
added a commit
to vaskoyudha/deeptutor-for-programmer-fork
that referenced
this pull request
Jul 25, 2026
…persistence [codex] fix mastery choice persistence and grading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ask_userturn events when possibleRoot cause
mastery_quizpreviously described itsoptionsargument as choice labels, sothe model could register only
["A", "B", "C", "D"]whileask_userheld theactual descriptions. The Question Bank then persisted the label-only array.
The same boundary also allowed
expected_answervalues such asStep 6, whilethe interactive card returned
C. Deterministic grading compared those valuesdirectly and marked a correct selection as wrong.
User impact
Choice questions now retain the same full option text shown to learners, and
correct card selections are graded against normalized labels. Bare label-only
registrations fail fast so the agent can retry with complete data.
Validation
ruff check deeptutor/capabilities/mastery/tools.py deeptutor/learning/tests/test_mastery_tools.pyruff format --check deeptutor/capabilities/mastery/tools.py deeptutor/learning/tests/test_mastery_tools.pypython -m pytest -q deeptutor/learning/tests/test_mastery_tools.py(16 passed)Step 6→CnormalizationFixes #603