fix: translate missing English settings-tour steps#572
Merged
pancacake merged 2 commits intoJun 19, 2026
Conversation
vaskoyudha
added a commit
to vaskoyudha/deeptutor-for-programmer-fork
that referenced
this pull request
Jul 25, 2026
…ders # Conflicts: # web/locales/en/app.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three of the eleven settings-tour steps shipped with placeholder values equal to their translation key, so the English onboarding tour rendered raw keys instead of copy. The Appearance (step 1), Status (step 2) and Tools (step 10) steps showed
settingsTour.appearance.title,settingsTour.status.desc, etc. directly to the user.settingsTour.appearance.titlesettingsTour.appearance.titleAppearancesettingsTour.appearance.descsettingsTour.appearance.descChoose the visual theme and interface language — changes apply immediately.settingsTour.status.titlesettingsTour.status.titleStatussettingsTour.status.descsettingsTour.status.descCheck the health of the backend and each service at a glance. Shows Pending when your draft diverges from the runtime.settingsTour.tools.titlesettingsTour.tools.titleToolssettingsTour.tools.descsettingsTour.tools.descToggle the user-selectable tools here; locked tools mount automatically when the chat agent needs them.The other 8 steps were already translated, and the
zhlocale had all 11 — only the English copy for these three was left as a TODO. New copy mirrors the existingzhtranslations and the tone of the already-translated steps.Root cause: introduced when the settings tour landed (
90a2c14c, v1.4.0-beta follow-ons) — the commit that added allsettingsTour.*keys filled in 8 steps and left 3 askey: keyplaceholders.i18n:paritydidn't catch it because the keys exist in both locales; only the values were untranslated.Related Issues
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
Additional Notes
Adds
web/tests/i18n-placeholders.test.ts: scans every English locale file and fails when a namespaced identifier key (lowercase dotted, e.g.settingsTour.*) has a value identical to its key — the exact shape of this bug. Plain-English keys ("Back") and proper nouns ("Chart.js", starts uppercase) are excluded, so there are no false positives. Verified it flags all 6 placeholders on the pre-fix file and passes on the fix.Testing:
web/testsnode suite 139/139 pass (incl. 2 new);npm run i18n:parityOK; rebuilt the Docker image and confirmed the production.nextbundle serves the real strings with no remaining placeholder values.Screenshots