feat: discoverable profile rename and auto-name by provider#571
Merged
Conversation
vaskoyudha
added a commit
to vaskoyudha/deeptutor-for-programmer-fork
that referenced
this pull request
Jul 25, 2026
# Conflicts: # web/components/settings/ServiceConfigEditor.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two related papercuts in the Settings profile sidebar (shared by LLM / Embedding / Search):
This PR:
Rename profilelabel. Double-click still works.nextProfileNameinweb/components/settings/profile-naming.ts).No new i18n strings (reuses the existing
Rename profilekey). LLM / Embedding / Search all benefit, since they share the sidebar and the provider→name logic.💬 Open to discussion
Happy to adjust before merging if you see it differently — e.g.:
Related Issues
No existing issue for this change — searched open/closed issues and PRs; none cover it. Happy to open one if preferred.
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
pre-commit runon the changed files — all hooks pass.Screenshots
Rename affordance — a pencil button is now visible in each profile row. The name also tracks the provider until customized (here it reads
DuckDuckGobecause the profile hasn't been renamed):Inline rename — clicking the pencil (or double-click) opens the rename field in place:
Additional Notes
Note on stacking (#570)
This touches
web/components/settings/ServiceConfigEditor.tsx, same as #570 (Search field visibility). The changes are in different regions (sidebar/rename vs. provider field rendering), so the only collision is an adjacent import line. To keep history clean I'd merge #570 first, then rebase this branch ontodev(trivial) before merging.Verification
tsc --noEmit(full project) — cleannode --test— full web suite green (137 tests), incl. newtests/profile-naming.test.ts(6 cases: auto name tracks provider, empty name filled, custom name preserved, empty new label no-op, whitespace-insensitive, same-provider no-op)eslint— 0 errors