fix(web): preserve math before citation linkification#540
Merged
Conversation
thakrarsagar
force-pushed
the
fix/math-citation-rendering
branch
from
June 2, 2026 19:41
a4b7225 to
a38a644
Compare
thakrarsagar
marked this pull request as ready for review
June 2, 2026 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a markdown rendering regression where numeric arrays inside LaTeX math were treated as citations before KaTeX rendered them.
The citation normalizer already protected fenced and inline code, but it did not protect math spans. As a result, vectors such as
[1, 1, 2]inside\[...\]were rewritten into reference links first. KaTeX then received markdown link syntax inside math and displayed a red parse error instead of the formula.This change masks display and inline math spans before citation linkification, then restores them afterward. Citation links outside math still behave the same way.
Related Issues
N/A (no existing issue found)
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
pre-commit run --all-filesand fixed any issues.Additional Notes
Root cause:
normalizeMarkdownForDisplay()ran citation linkification before math rendering while protecting code spans only. Numeric vectors and weighted expressions are valid math content, but they also match the citation-link pattern.Validation:
npm run test:node— 108 passednpm run build— passeduv run --with pre-commit pre-commit run --files web/lib/markdown-display.ts web/tests/markdown-display.test.ts— passedpre-commit run --all-fileswas attempted viauv run --with pre-commit pre-commit run --all-files; it failed because hooks reformatted 34 unrelated files already present on thedevbase (end-of-file-fixer,ruff-format, andprettier). Those unrelated hook changes were not included in this PR.