Fix SQLite FD Exhaustion#493
Merged
Merged
Conversation
Collaborator
|
Thanks for your contribution! |
pancacake
added a commit
that referenced
this pull request
Jun 11, 2026
#493 (sqlite): route _initialize() through the _connect() contextmanager (the one remaining raw sqlite3.connect FD leak); document the auto-commit contract so the redundant explicit commits are understood. #529 (book): - _strip_thinking_preamble: guard `{ not in text` before rindex() so plain prose (refusals/errors) no longer raises ValueError -> ERROR block; hoist json import to module top. - llm_json: honor caller max_tokens as max(max_tokens, 2600) instead of discarding it; bump default to 2600; fix stale 'minimal' docstring -> 'low'. - engine.compile_page: rebuild OVERVIEW pages deterministically via _materialize_overview_page on force, instead of running the generic LLM compiler over hand-built intro/concept-graph/index blocks. - kb_health.scan_log_health: key repeated-failure detection on the op, not the free-text message, removing false positives/negatives + dead block_error. - services/__init__: drop orphaned notebook_manager lazy-import + __all__ entry. - PageReader.tsx: restore t() i18n on regenerate buttons; add 'Regenerating…'. - remove PATCHES.md (developer-local scratch notes). #484 (zulip): also match the disambiguated @**Name|user_id** mention form; make the docstring truthful; add coverage. #500: remove stray PR_DESCRIPTION.md committed to repo root. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vaskoyudha
added a commit
to vaskoyudha/deeptutor-for-programmer-fork
that referenced
this pull request
Jul 25, 2026
Wrap _connect() in a contextmanager that closes the connection after use, preventing one leaked file descriptor per query. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
vaskoyudha
added a commit
to vaskoyudha/deeptutor-for-programmer-fork
that referenced
this pull request
Jul 25, 2026
…#529/HKUDS#484 HKUDS#493 (sqlite): route _initialize() through the _connect() contextmanager (the one remaining raw sqlite3.connect FD leak); document the auto-commit contract so the redundant explicit commits are understood. HKUDS#529 (book): - _strip_thinking_preamble: guard `{ not in text` before rindex() so plain prose (refusals/errors) no longer raises ValueError -> ERROR block; hoist json import to module top. - llm_json: honor caller max_tokens as max(max_tokens, 2600) instead of discarding it; bump default to 2600; fix stale 'minimal' docstring -> 'low'. - engine.compile_page: rebuild OVERVIEW pages deterministically via _materialize_overview_page on force, instead of running the generic LLM compiler over hand-built intro/concept-graph/index blocks. - kb_health.scan_log_health: key repeated-failure detection on the op, not the free-text message, removing false positives/negatives + dead block_error. - services/__init__: drop orphaned notebook_manager lazy-import + __all__ entry. - PageReader.tsx: restore t() i18n on regenerate buttons; add 'Regenerating…'. - remove PATCHES.md (developer-local scratch notes). HKUDS#484 (zulip): also match the disambiguated @**Name|user_id** mention form; make the docstring truthful; add coverage. HKUDS#500: remove stray PR_DESCRIPTION.md committed to repo root. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the SQLite Implementation leaks file descriptors/connections. That means that when they get exhausted (by default thats after 1024 FDs), querying the DB fails. This fixes that.
Related Issues
Module(s) Affected
agentsapiconfigcoreknowledgeloggingservicestoolsutilsweb(Frontend)docs(Documentation)scriptstests...Checklist
pre-commit run --all-filesand fixed any issues.Additional Notes
Add any other context or screenshots about the pull request here.