Repository navigation
Conversation
Note names containing '#', '?', '%' or spaces were interpolated raw into the request URL, so the HTTP client cut them at the fragment/query delimiter and create/update could overwrite a different note. Fixes HKUDS#565
kevin9327
requested review from
omerarslan0,
yuh-yang and
zhangxilong-43
as code owners
October 17, 2026 03:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
existing-cli-fix
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Vault operations in the obsidian harness built the request URL by raw string interpolation of the note path. A name like
notes/C#cheatsheet.mdwas sent as/vault/notes/C(the rest became a URL fragment), andWhat?.mdlost everything after?. In the worst case,create_note/update_note/append_notesilently overwrote a different, existing note.core/vault.pynow percent-encodes the path withurllib.parse.quote(path, safe="/")for list/read/create/update/delete (and append, which goes through read/update). Folder separators are kept. Plain paths are unchanged, so existing tests still pass.Fixes #565
Type of Change
Testing
test_note_paths_with_reserved_characters_are_percent_encoded(#,?,%,&, space, leading/, and folder listing).pytest cli_anything/obsidian/tests/test_core.py: the new test fails without the fix (1 failed, 52 passed) and passes with it (53 passed).AI assistance
An AI coding agent (Grok Bot) helped write this change. I reproduced the bug, reviewed the diff, and ran the tests.