Download the artifacts for this pull request:

• hdr-ryujinx
• hdr-switch

Everything seems to be working as described, tested every detail listed including training mode resets the random number, luigi panting counting towards the counter, damage decay including the lower bound, storage lasting across deaths.
Animation looks a bit off if you put off cancelling a misfire charge until near the end where luigi is about to give up, as the animation sort of resets for a short bit to the standard charging part but then jumps back to him giving up quickly. Seems to have about the same timing it would have normally and works fine functionally so just a small note

Thanks for the feedback. I forgot to remove the effect at the right time, so I will resolve that in a little bit.

Leaving this as a general comment (havent had time to actually do a review yet), but I wonder if it would be cool to add in ParamModule an entry for the "effect color" of each character's skin. So like, for example, luigi would have 8 values in a "colors" field that indicates what color any of his special effects should be based on skin slot. That would let us specify things like this, or like inkling's paint colors, in a more clean manner that would be consistent across characters. We could just call something like fighter.get_skin_color or fighter.get_effect_color to access it cleanly. Then any vfx we make will use those values. Might be a lot of work, might be worth it. Could always start with python-script-generated white vfx for all characters, and then when characters use them (like luigi or inkling) we can set real values. Users can change them if they have their own colors. Or we can make a special colors.json equivalent for this.

Leaving this as a general comment (havent had time to actually do a review yet), but I wonder if it would be cool to add in ParamModule an entry for the "effect color" of each character's skin. So like, for example, luigi would have 8 values in a "colors" field that indicates what color any of his special effects should be based on skin slot. That would let us specify things like this, or like inkling's paint colors, in a more clean manner that would be consistent across characters. We could just call something like fighter.get_skin_color or fighter.get_effect_color to access it cleanly. Then any vfx we make will use those values. Might be a lot of work, might be worth it. Could always start with python-script-generated white vfx for all characters, and then when characters use them (like luigi or inkling) we can set real values. Users can change them if they have their own colors. Or we can make a special colors.json equivalent for this.

I don't really think that this is a worth while idea, since most people will be playing with cosmetic mods anyways.