Skip to content

B-reverse rework#396

Merged
jobrien97 merged 3 commits into
devfrom
issue-388-b-reverses
Mar 29, 2022
Merged

B-reverse rework#396
jobrien97 merged 3 commits into
devfrom
issue-388-b-reverses

Conversation

@jobrien97

@jobrien97 jobrien97 commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator

B-reverse code has been reworked to better emulate vanilla B-reverse input/behavior.

Also fixes an issue that let you B-reverse charge specials after the first 5 frames (intended B-reverse window).

Fixes #388
Fixes #234

@jobrien97 jobrien97 added bug Something isn't working enhancement New feature or request engine For working on engine changes semver:patch labels Mar 28, 2022
@jobrien97 jobrien97 requested a review from techyCoder81 March 28, 2022 22:46
@github-actions

github-actions Bot commented Mar 28, 2022

Copy link
Copy Markdown

Download the artifacts for this pull request:

Only for Developers

@techyCoder81 techyCoder81 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of stuff that could be cleaned up here

Comment thread fighters/common/src/opff/tech.rs
Comment thread fighters/common/src/opff/tech.rs
Comment thread fighters/donkey/src/opff.rs Outdated
Comment thread fighters/ganon/src/opff.rs Outdated
Comment thread fighters/ike/src/opff.rs Outdated
Comment thread fighters/pacman/src/opff.rs Outdated
Comment thread fighters/pikmin/src/opff.rs Outdated
Comment thread fighters/richter/src/opff.rs Outdated
Comment thread fighters/toonlink/src/opff.rs
Comment thread fighters/younglink/src/opff.rs Outdated
@jobrien97 jobrien97 requested a review from techyCoder81 March 29, 2022 00:15

@techyCoder81 techyCoder81 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice amount of cleanup, lgtm

@jobrien97 jobrien97 merged commit a7c18ad into dev Mar 29, 2022
SuddyN added a commit that referenced this pull request Nov 5, 2025
SuddyN added a commit that referenced this pull request Nov 5, 2025
This reverts commit 5cc0d76, reversing
changes made to 74064ed.
SuddyN added a commit that referenced this pull request Nov 5, 2025
Revert "Merge pull request #396 from HDR-Development/throw-tumble"
SkewedAskew pushed a commit that referenced this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working engine For working on engine changes enhancement New feature or request semver:patch

Projects

None yet

2 participants