Skip to content

Ground movement refactor#390

Merged
jobrien97 merged 17 commits into
devfrom
job
Apr 2, 2022
Merged

Ground movement refactor#390
jobrien97 merged 17 commits into
devfrom
job

Conversation

@jobrien97

@jobrien97 jobrien97 commented Mar 28, 2022

Copy link
Copy Markdown
Collaborator
  • Dash energy application moved to opff
  • Backwards dash momentum was previously still being applied on frame 1 of smash turn; you now properly halt during smash turn, which makes dash dances even snappier than before
  • Frame-perfect pivot cancels now properly apply slide into next action
  • Frame 3 perfect pivots removed
  • Various cleanup

Resolves #353
Fixes #385
Fixes #222

- Dash energy applied in opff
- Backwards dash momentum was previously still being applied on frame 1 of smash turn; you now properly halt during smash turn, which makes dash dances even snappier than before
- Frame-perfect pivot cancels now properly apply slide into next action
- Frame 3 perfect pivots removed
- Various cleanup
@github-actions

github-actions Bot commented Mar 28, 2022

Copy link
Copy Markdown

Download the artifacts for this pull request:

Only for Developers

techyCoder81
techyCoder81 previously approved these changes Mar 28, 2022

@techyCoder81 techyCoder81 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am simply not going to read all of this. it is too much at once, as always. i look forward to when we can ditch most of our energy bs and half of our stapled mechanics and do it right instead

@techyCoder81

Copy link
Copy Markdown
Collaborator

In retrospect that read very aggressively and I apologize for that

Comment thread fighters/common/src/general_statuses/dash.rs
Comment thread fighters/common/src/general_statuses/dash.rs
Comment thread fighters/common/src/general_statuses/dash.rs
Comment thread fighters/common/src/general_statuses/dash.rs
Comment thread fighters/common/src/general_statuses/turn.rs
Comment thread fighters/common/src/opff/physics.rs
Comment thread fighters/common/src/opff/shotos.rs
Comment thread fighters/common/src/shoto_status.rs
@jobrien97 jobrien97 added enhancement New feature or request engine For working on engine changes semver:feature semver:patch and removed semver:patch semver:feature labels Apr 1, 2022
@jobrien97 jobrien97 merged commit 457cef3 into dev Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine For working on engine changes enhancement New feature or request semver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sora Neutral B issue (Nightly) Ground movement adjustments Characters sometime slide backwards when dashing forward, no I don't mean moonwalking.

2 participants