Fix double traction during sliding attacks#320
Merged
Conversation
|
Download the artifacts for this pull request: Only for Developers |
techyCoder81
approved these changes
Mar 19, 2022
techyCoder81
left a comment
techyCoder81
left a comment
Collaborator
There was a problem hiding this comment.
approving for now, but not a fan of this impl. Looking forward to when we can do it right, from the bottom up, rather than from the top down.
Collaborator
|
there are reports that this is not resolving the issue for certain moves in the #testing channel |
techyCoder81
requested changes
Mar 19, 2022
techyCoder81
left a comment
techyCoder81
left a comment
Collaborator
There was a problem hiding this comment.
there are reports that it still has edge cases and does not work uniformly. Shouldnt we be checking kinetic type or something instead?
Collaborator
|
made a new ticket to track the fact that this still needs work. However, merging these changes because they will at least improve the current problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double traction is no longer active during motion-based attacks (moves that change your position)
Fixes #313
Fixes #306