Roy Side-B Effects Polish#2603
Merged
SuddyN merged 3 commits intoOct 17, 2025
Merged
Conversation
A PR to clean up Roy's Side-B effects. The current iteration calls both roy's normal sword glow and the special sword glow which can be seen during the last frames of any Side-B attack.
|
Download the artifacts for this pull request: |
Reduces Trail length size for cleaner visuals
Collaborator
|
is this PR superseded by the larger sword trails PR? |
SuddyN
added
aesthetics
Contributor
Author
|
It is not. The changes here are separate |
SuddyN
approved these changes
Oct 17, 2025
Collaborator
|
I will merge this and the boomerang PR after the sword trails PR, when that is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Assets: hdr-roy-side-b.zip
The current iteration of Side-B calls both Roy's normal sword glow and the special sword glow which can be seen during the last frames of any Side-B attack. This PR cleans that up, redesigns his Sword trails, and adds a fire effect on his sword for any attacks that cause fire damage.
Side Special All Variants
[$] Removed normal sword glow
[$] Sword trail textures redesigned
Side Special Side 4:
[$] Added Fire Effect to Sword
Old:
New:
Side Special Back 4:
[$] Added Fire Effect to Sword
Old:
New:
Side Special Up 4:
[$] Added Fire Effect to Sword
Old:
New:
Side Special Down 3:
[$] Added Fire Effect to Sword
Old:
New:
Side Special Down 4:
[$] Added Fire Effect to Sword
Old:
New:
