Skip to content

Byleth bugfix and adjustments#2477

Merged
WuBoytH merged 8 commits into
HDR-Development:devfrom
5-Thousand:byleth-bugfix-and-adjustments
Aug 1, 2024
Merged

Byleth bugfix and adjustments#2477
WuBoytH merged 8 commits into
HDR-Development:devfrom
5-Thousand:byleth-bugfix-and-adjustments

Conversation

@5-Thousand

@5-Thousand 5-Thousand commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Some light touch ups to Byleth's kit as well as a fix to a long standing issue with their neutral special.

Changelog

Forward Air

  • [+] Sour Spot Angle 361 -> 49

Up Tilt

  • [/] Shoulder hitbox removed, hilt and arm hitboxes moved inwards to compensate, blade and tipper hitboxes unchanged
Old New
utiltStartA utiltStartB
utiltMidA utiltMidB

Forward Tilt

  • [+] Sour spot hitboxes have been shifted inwards to more closely match up tilt's tippers, overall range unchanged
  • [/] Shoulder hitbox removed, hilt and arm hitboxes moved inwards to compensate
Old New
ftiltStartA ftiltStartB
ftiltmidA ftiltMidB

Neutral Special

  • [*] Bug fixed regarding landing during neutral special
  • [/] Multipliers on horizontal speed have been changed to preserve more momentum in the air

@moklmaru moklmaru added good first issue Good for newcomers character change For working on general character changes semver:patch labels Jul 31, 2024
@github-actions

github-actions Bot commented Jul 31, 2024 •
edited
Loading

Copy link
Copy Markdown

Download the artifacts for this pull request:

WuBoytH
WuBoytH previously approved these changes Jul 31, 2024
View reviewed changes

@WuBoytH WuBoytH left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor whitespace issue to fix but the rest looks good

Comment thread fighters/master/src/acmd/specials.rs Outdated
@WuBoytH WuBoytH added the balance approved This change has been approved for balance label Aug 1, 2024
@WuBoytH WuBoytH merged commit e2efaaa into HDR-Development:dev Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WuBoytH WuBoytH WuBoytH left review comments

Assignees

No one assigned

Labels

balance approved This change has been approved for balance character change For working on general character changes good first issue Good for newcomers semver:patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@5-Thousand @WuBoytH @moklmaru