Dedede Down B Rework and other adjustments by SirTanknSpank · Pull Request #2473 · HDR-Development/HewDraw-Remix

SirTanknSpank · 2024-07-30T15:39:02Z

A new down b and some other big adjustments for the plus-sized penguin.

Assets: dedede-assets.zip

Changelog

Forward Tilt

The goal here is to make the move more consistent, rather than having people fall out before the final hit.

Multihits:
- [/] Hammer hitboxes adjusted to be on the hammer2 bone, as opposed to the top bone
- [/] Number of hitboxes: 5 -> 3
Finisher:
- [+] Hammer hitbox size: 7.0 units -> 7.5 units

Old:

New:

Down Tilt

This should make it match P+ frame data

[+] Animation speed increased
[/] Active Frames: 7-20 -> 6-14
[+] FAF: 37 -> 31

Down Throw

[-] BKB: 50 -> 65
[/] KBG: 80 -> 60

Up Throw

[-] KBG: 80 -> 90

Up Special

[!] Now stops all momentum before the jump
[!] Can now sweetspot ledge before the jump
[+] Landing star offset: 7 units -> 9 units

Side Special

A small buff, as well as making smash gordo have more of a difference compared to tilt gordo.
Also a QoL change to make it so aerial down angled gordo no longer forces a fastfall.

[+] Smash Gordo Speed Multiplier: 1.25x -> 1.6x
[+] FAF: 55 -> 51
[/] Fastfall window: Anytime lmao -> Frame 19+

Gordo

Partial revert of gordo to have knockback scaling again. This should make it better at higher %'s while still keeping it low knockback all around

[+] Shieldstun Multiplier: 0.7x -> 0.8x
[/] FKB: 60 -> 0
[/] KBG: 110 -> 55
[/] BKB: 0 -> 50

Gordo Dash

These changes should make gordo dash feel way better and actually worth using

[+] Air Dash Speed Multiplier: 1.5x -> 1.8x
[+] Grounded dash speed multiplier: 1x -> 1.2x
[+] FAF: 56 -> 42
[/] Retoss Angle: 120 -> 60

Down Special

Reworked into Jet Hammer Spin! This is a high risk move where Dedede takes out his jet hammer and launches himself forward while spinning. The move can be charged to deal more damage, as well as gaining an extra set of spins for every 30 frames of charge.

unchargedspin.mp4

prayingemoji.mp4

The move can be charged for 80 frames, giving a total of 3 sets of spins.

Attack Data
- Startup: 18 Frames
- Damage: 14% , Maximum of 18% if fully charged
- Angle: 361
- KBG: 60
- BKB: 85
- Self Damage: 12% if fully charged
- Goes into special fall if used in the air

Other important things to note:

Armor is removed

Side Taunt (Facing Right)

[+++] Dedede will now equip his mask if special is held on frame 3

TheMask.mp4

and also removing an old comment

…knSpank/HewDraw-Remix into fat-penguin-down-b-rework

github-actions · 2024-07-30T15:45:16Z

Download the artifacts for this pull request:

WuBoytH · 2024-07-30T16:41:34Z

+
+    if MotionModule::is_end(fighter.module_accessor) &&
+    StatusModule::situation_kind(fighter.module_accessor) == SITUATION_KIND_AIR{
+        MotionModule::change_motion(fighter.module_accessor, Hash40::new("fall_special"), 0.0, 1.0, false, 0.0, false, false);


this line shouldn't be necessary if you're already changing into the FALL_SPECIAL status.

WuBoytH · 2024-07-31T04:50:13Z

+
+    if MotionModule::frame(fighter.module_accessor) > 30.0 && StatusModule::is_situation_changed(fighter.module_accessor){
+        if StatusModule::situation_kind(fighter.module_accessor) == *SITUATION_KIND_AIR {
+            MotionModule::change_motion(fighter.module_accessor, Hash40::new("fall_special"), 0.0, 1.0, false, 0.0, false, false);


This line can be removed

WuBoytH · 2024-07-31T04:51:28Z

+unsafe extern "C" fn special_lw_attack_exec(fighter: &mut L2CFighterCommon) -> L2CValue{
+    //Continue spinning if the button is held down
+    if ControlModule::check_button_on(fighter.module_accessor, *CONTROL_PAD_BUTTON_SPECIAL) 
+    && MotionModule::frame(fighter.module_accessor) < 25.0 


Please make these frame checks a status flag that's enabled in ACMD instead

- Remove shield bonk - Re-implement charging - Reduce FAF By 3 frames - Startup increased by 3 frames - Re-implement status scripts - Removing some unused variables

SuddyN · 2024-08-31T19:33:55Z

    }
    frame(lua_state, 25.0);
-    FT_MOTION_RATE(agent, 35.0 / (65.0-26.0));    
+    FT_MOTION_RATE(agent, 31.0 / (65.0-26.0));    


FT_MOTION_RATE_RANGE(agent, 26.0, 65.0, 31.0)

new standard is to use this function, rather than math. usage is agent, start_frame, end_frame, duration

SuddyN · 2024-08-31T19:34:07Z

    }
    frame(lua_state, 25.0);
-    FT_MOTION_RATE(agent, 35.0 / (65.0-26.0));    
+    FT_MOTION_RATE(agent, 31.0 / (65.0-26.0));    


FT_MOTION_RATE_RANGE(agent, 26.0, 65.0, 31.0)

SuddyN · 2024-08-31T19:34:36Z

+        }
+    }
+    frame(lua_state, 9.0);
+    FT_MOTION_RATE(agent, 7.0 / (27.0-10.0));


FT_MOTION_RATE_RANGE(agent, 10.0, 27.0, 7.0)

SuddyN · 2024-08-31T19:35:03Z

+        }
+    }
+    frame(lua_state, 9.0);
+    FT_MOTION_RATE(agent, 7.0 / (27.0-10.0));


FT_MOTION_RATE_RANGE(agent, 10.0, 27.0, 7.0)

SuddyN · 2024-08-31T19:38:10Z

+    if is_excute(agent) {
+        FT_MOTION_RATE(agent, 45.0/(23.0));
+    }


avoid using FT_MOTION_RATE or similar motion-rating functions inside an if is_excute(agent) conditional. This often causes problems for statuses that transition between air/ground motions when landing/falling, because the conditional fails in those circumstances

rewrite by just removing the conditional and keeping the motion rate

SuddyN · 2024-08-31T19:40:13Z

    if is_excute(agent) {
+        KineticModule::clear_speed_all(boma);
+        FT_MOTION_RATE(agent, 7.0/(31.0 - 22.0));
        AttackModule::clear_all(boma);
    }


SuddyN · 2024-08-31T19:40:43Z

+    if is_excute(agent) {
+        FT_MOTION_RATE(agent, 2.0);
+    }


SuddyN · 2024-08-31T19:43:57Z

+            if StatusModule::is_situation_changed(fighter.module_accessor){
+                MotionModule::set_rate(fighter.module_accessor, 1.4);
+            }


what are we doing here..? this will presumably just be overwritten by any motion rating done in the ACMD. maybe you are trying to solve a problem that is caused by placing motion rating calls inside an if is_excute(agent) conditional? Whatever it is, you probably do not need or want to set motion rate to 1.4 on StatusModule::is_situation_changed.

SuddyN · 2024-08-31T19:47:13Z

+            ModelModule::set_joint_translate(fighter.module_accessor, Hash40::new("shoulderr"), &Vector3f{x:3.0, y:rand, z:-1.0}, false, false); 
+            ModelModule::set_joint_translate(fighter.module_accessor, Hash40::new("waist"), &Vector3f{x:3.0, y:0.0, z:rand_waist}, false, false); 


random programmatic animation adjustments in opff... I hate it but it might be necessary for what you're doing? Honestly DSpecial charging should work based on two separate animations and statuses like a smash attack (but I won't ask you to make that change)

SuddyN · 2024-08-31T19:48:44Z

 special_hi_failure:
  extra:
-    cancel_frame: 41
+    cancel_frame: 98


is this to delay freefall?

- Reformatting motion rates - Adding side b status scripts - Refactoring gordo recatch - Also fixes some small bugs with side b and recatch

resolved

SirTanknSpank added 13 commits May 8, 2024 07:13

Init

a2dfbd3

Merge branch 'HDR-Development:dev' into fat-penguin-down-b-rework

69686e5

Revive this from the dead

3fce3e6

Bonk, multihit removal, flag rename and more

489bc90

Merge branch 'HDR-Development:dev' into fat-penguin-down-b-rework

29058eb

Effect and speed fixes

9dd0c57

Merge branch 'HDR-Development:dev' into fat-penguin-down-b-rework

b66b309

Actual mask toggle

c36460c

and also removing an old comment

Smol changes

586c8ef

Merge branch 'fat-penguin-down-b-rework' of https://github.com/SirTan…

e79bd0d

…knSpank/HewDraw-Remix into fat-penguin-down-b-rework

Moving fastfall gordo to frame 19+

fd642c3

Whoops

1145d72

Merge branch 'HDR-Development:dev' into fat-penguin-down-b-rework

b5fcd79

SkewedAskew added character change For working on general character changes semver:patch includes assets discussion ongoing Content has yet to be agreed upon labels Jul 30, 2024

WuBoytH requested changes Jul 30, 2024

View reviewed changes

Status Implementation Changes

2b2b23a

WuBoytH previously requested changes Jul 31, 2024

View reviewed changes

SirTanknSpank added 2 commits August 5, 2024 10:43

A ton of changes, it's basically a second rework

0e5cd02

- Remove shield bonk - Re-implement charging - Reduce FAF By 3 frames - Startup increased by 3 frames - Re-implement status scripts - Removing some unused variables

Changes for the new animations

986ce42

SuddyN previously requested changes Aug 31, 2024

View reviewed changes

Requested changes + Side B/Recatch refactor

aca1497

- Reformatting motion rates - Adding side b status scripts - Refactoring gordo recatch - Also fixes some small bugs with side b and recatch

WuBoytH changed the base branch from dev to pre-release September 13, 2024 16:29

moklmaru added balance approved This change has been approved for balance and removed discussion ongoing Content has yet to be agreed upon labels Sep 29, 2024

moklmaru merged commit 30a4fcc into HDR-Development:pre-release Sep 29, 2024

		ModelModule::set_joint_translate(fighter.module_accessor, Hash40::new("shoulderr"), &Vector3f{x:3.0, y:rand, z:-1.0}, false, false);
		ModelModule::set_joint_translate(fighter.module_accessor, Hash40::new("waist"), &Vector3f{x:3.0, y:0.0, z:rand_waist}, false, false);

Uh oh!

Conversation

SirTanknSpank commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

Forward Tilt

Down Tilt

Down Throw

Up Throw

Up Special

Side Special

Gordo

Gordo Dash

Down Special

Side Taunt (Facing Right)

Uh oh!

github-actions Bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SuddyN Aug 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SirTanknSpank commented Jul 30, 2024 •

edited

Loading

github-actions Bot commented Jul 30, 2024 •

edited

Loading

SuddyN Aug 31, 2024 •

edited

Loading