Correctly install ICs opff (fixes crashes)#133
Merged
Merged
Conversation
jobrien97
changed the title
|
Download the artifacts for this pull request: Only for Developers |
techyCoder81
approved these changes
Feb 17, 2022
techyCoder81
left a comment
techyCoder81
left a comment
Collaborator
There was a problem hiding this comment.
I would love to see this done using boma->partner equivalents instead of using ID and a local static array, because we know BattleObjectModuleAccessor has a partner field that the game uses in ICs status scripts to get nana from popo, and vice versa, but I don't know if thats available to us right now in skyline.
Using VarModule would also be better than a static array, but given that this is a crash fix, imo its a priority change.
Collaborator
|
@blu-dev probably knows how we can get that data - know its been discovered already in ghidra the part of the struct that stores partner, but I can't recall what it was. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131