Support escaped characters #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
approved these changes
Aug 24, 2024
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Aug 25, 2024
…notriddle Update minifier to 0.3.1 It adds support for escaped characters. PR is GuillaumeGomez/minifier-rs#111. r? `@notriddle`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 25, 2024
…notriddle Update minifier to 0.3.1 It adds support for escaped characters. PR is GuillaumeGomez/minifier-rs#111. r? ``@notriddle``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 25, 2024
…notriddle Update minifier to 0.3.1 It adds support for escaped characters. PR is GuillaumeGomez/minifier-rs#111. r? ```@notriddle```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 25, 2024
…notriddle Update minifier to 0.3.1 It adds support for escaped characters. PR is GuillaumeGomez/minifier-rs#111. r? ````@notriddle````
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 25, 2024
Rollup merge of rust-lang#129511 - GuillaumeGomez:update-minifier, r=notriddle Update minifier to 0.3.1 It adds support for escaped characters. PR is GuillaumeGomez/minifier-rs#111. r? ````@notriddle````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for escaped characters prefixed by a backslash. However it does not fully implements the spec (https://www.w3.org/TR/CSS21/syndata.html#characters): support for ISO code escaping sequences and backslashes followed by a newline in strings will need to be implemented in a separate PR.
Fixes #110