Fix save content with newer Vte - #2218
Merged
Merged
Conversation
Works with vte=0.68.0 See Guake#1958
Collaborator
|
Sorry about the slow reply, been bogged down for a bit. Built and ran, and I get the following traceback: My terminal I presume is an older version of VTE because I'm able to use save content for the full terminal history without the patch. I suspect that the condition in the if statement reliant on get_text_range() may need to be reworked. |
PhungXuanAnh
added a commit
to PhungXuanAnh/guake
that referenced
this pull request
Nov 26, 2024
fix this bug: Guake#1958 copy the fix from this PR: Guake#2218
PhungXuanAnh
added a commit
to PhungXuanAnh/guake
that referenced
this pull request
Nov 26, 2024
fix this bug: Guake#1958 copy the fix from this PR: Guake#2218
Co-authored-by: Phùng Xuân Anh <[email protected]>
Davidy22
approved these changes
Dec 18, 2024
Davidy22
left a comment
Davidy22
left a comment
Collaborator
There was a problem hiding this comment.
Patch looks like it works now, but there's some unfortunate behavior with the way this interacts with the hide on focus loss option. It seems like a common issue across everything that pops a dialog, maybe we need a utlity wrapper for dialogs that'll temporarily disable hide on lose focus. That'd be out of scope for this PR though, merging this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Save Content feature with newer versions of Vte. The entire contents, including scrollback, will be saved.
See #1958 I left the old method there as well, in case get_text_range doesn't work for some reason. I don't have a system with an older version of Vte to test.