Skip to content

Allow splitting with specified size using --split-vertical or --split-horizontal - #2208

Merged
Davidy22 merged 1 commit into
Guake:masterfrom
welhoilija:Allow-splitting-with-specified-size
Oct 14, 2023
Merged

Allow splitting with specified size using --split-vertical or --split-horizontal#2208
Davidy22 merged 1 commit into
Guake:masterfrom
welhoilija:Allow-splitting-with-specified-size

Conversation

@welhoilija

Copy link
Copy Markdown

Introduces the ability to specify split percentages when using the --split-vertical or --split-horizontal flags, as discussed in #1931. Now, users can control the size of the new pane by providing an optional split percentage, making terminal splitting more flexible and user-friendly.

@welhoilija welhoilija changed the title Allow splitting with specified size using --split-vertical or --split-horizontal #1931 Allow splitting with specified size using --split-vertical or --split-horizontal Oct 12, 2023

@Davidy22 Davidy22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, passes checks, but some edge cases to consider.

Comment thread guake/main.py Outdated
@welhoilija
welhoilija force-pushed the Allow-splitting-with-specified-size branch from 2d608c4 to 99cc517 Compare October 13, 2023 08:16
@welhoilija
welhoilija requested a review from Davidy22 October 13, 2023 10:27
@welhoilija

Copy link
Copy Markdown
Author

Sry, will run the formatter once i get home, my bad.

@welhoilija
welhoilija force-pushed the Allow-splitting-with-specified-size branch from 99cc517 to f30aa12 Compare October 13, 2023 10:42
@welhoilija
welhoilija force-pushed the Allow-splitting-with-specified-size branch from f30aa12 to dbe8ab9 Compare October 13, 2023 13:00
@welhoilija

Copy link
Copy Markdown
Author

Should be good now, I think there was also some release note that had some trailing whitespace.

@Davidy22 Davidy22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good now, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants