Prevent the use of non-image files as a background image - #2206
Conversation
|
The change looks fine, but looks like code style checks are moaning. Running black should resolve this, I assume it's because of the very long line that the |
|
Still a red cross, you should be able to enable CI on your fork to get faster feedback, running |
|
Same check is complaining, if you just run black on the file it should do the formatting for you. Is |
make gives me errors. I think pipenv is the problem here. |
|
You can also run |
Please follow these steps before submitting a new Pull Request to Guake:
rebase on latest HEAD:
hack your change
to execute the code styling, checks and unit tests:
$ make style check reno-lint testdescribe your change in a slug file for automatic release note
generation, using:
and edit the created file in
releasenotes/notes/.You can see how
renoworks usingpipenv run reno --help.Please use a generic slug (eg, for translation update,
use
translation, for bugfix usebugfix,...)create new commit message
If your change is related to a GitHub issue, you can add a reference
using
#123where 123 is the ID of the issue.You can use
closes #123to have GitHub automatically close the issuewhen your contribution get merged
Semantic commit is supported (and recommended). Add one of the following
line in your commit messages:
Fixes #2205