Enable the use of AyatanaAppIndicator - #2200
Conversation
This uses the newer successor to AppIndicator3 for the tray icon implementation, with a fallback to the older AppIndicator3 if the Ayatana version is not found. AyatanaAppIndicator is backwards compatible with AppIndicator3, so the API remains the same. The icon is also fixed. Ref BuddiesOfBudgie/budgie-desktop#446 Fixes Guake#433 sem-ver: bug-fix Signed-off-by: Evan Maddock <[email protected]>
|
Sorry about the delay, been a little buried. Couldn't reproduce, can't confirm for myself but if this works for you then it should be fine. CI is complaining about black, a passthrough of that should silence that and this'll be good to go. |
Signed-off-by: Evan Maddock <[email protected]>
|
No problem, I know the feeling, heh. |
|
Linter's now objecting to the inline import. The pylint exclusion comments might need to be on the first line where the import keyword is, I think there should be a way for you to turn CI on with your fork so that you can get feedback from our checks faster. Locally, |
Signed-off-by: Evan Maddock <[email protected]>
|
Hopefully this does it. Thanks for pointing out |
Davidy22
left a comment
Davidy22
left a comment
There was a problem hiding this comment.
Looks good, green checks on CI, merging.
2 participants
This uses the newer successor to AppIndicator3 for the tray icon implementation, with a fallback to the older AppIndicator3 if the Ayatana version is not found. AyatanaAppIndicator is backwards compatible with AppIndicator3, so the API remains the same. The icon is also fixed.
Tested on Solus 4.4 with Budgie Desktop 10.8.
Ref BuddiesOfBudgie/budgie-desktop#446
Fixes #433