Reintroduce execute_command dbus hook - #2057
Merged
Merged
Conversation
ghost
mentioned this pull request
Collaborator
Author
|
@mlouielu I'm willing to use admin power to force my other PRs through but this one particularly I do want to get looked at due to security implications |
Command now always creates a new tab to execute the command in
Collaborator
Author
|
@mlouielu I've gone and forced the other PRs in limbo that aren't quite as sensitive as this one, still would like to get this one looked at before merge. |
|
Waiting for this fix! |
Collaborator
Author
|
@mlouielu I'm going to just push this if it comes close to a second month in limbo |
Collaborator
Author
|
Just going to push this now. This spending as long as it did in limbo I think means I don't need to wait for review to merge things since anyone else who could review doesn't seem to be active |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command now always creates a new tab to execute the command in
Alternate resolution to #2042 decided upon after some amount of discussion.