Skip to content

Revert "ci: no pipeline on pull_request" - #2018

Merged
gsemet merged 1 commit into
Guake:masterfrom
Davidy22:rev
Jan 22, 2022
Merged

Revert "ci: no pipeline on pull_request"#2018
gsemet merged 1 commit into
Guake:masterfrom
Davidy22:rev

Conversation

@Davidy22

Copy link
Copy Markdown
Collaborator

This reverts commit 517745d.

Despite assurance that removing pull_request wouldn't wipe CI runs from pull requests, we can see in #2017 that removing pull_request wipes CI runs from pull requests.

@Davidy22
Davidy22 requested review from gsemet and mlouielu January 22, 2022 07:34
@Davidy22

Copy link
Copy Markdown
Collaborator Author

Hold on, why did it run here, but not in the other PR? Well since this apparently wasn't stopped, closing.

@Davidy22 Davidy22 closed this Jan 22, 2022
@Davidy22
Davidy22 deleted the rev branch January 22, 2022 07:40
@Davidy22
Davidy22 restored the rev branch January 22, 2022 07:41
@Davidy22

Copy link
Copy Markdown
Collaborator Author

Actually, maybe CI ran because this pull request is restoring CI? The next time another pull request comes in we can see if CI isn't run again on it.

@Davidy22 Davidy22 reopened this Jan 22, 2022
@gsemet

gsemet commented Jan 22, 2022

Copy link
Copy Markdown
Member

Agree, apparently it does not work exactly like in gitlab. My mistake

@gsemet
gsemet merged commit c3ea8fe into Guake:master Jan 22, 2022
@Davidy22
Davidy22 deleted the rev branch January 22, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants