Fix arbitrary execution via dbus security flaw - #2017
Merged
Conversation
Highlighted in Guake#1796. Also removed comments that won't be true or relevant with this change. These changes orphan the execute_command_by_uuid() method, but the method can probably still be used elsewhere.
Collaborator
Author
|
@gsemet, it really doesn't look like the pull request hook works the way you said it does. Looks a lot to me like CI isn't being run on pull requests. |
Member
|
Ok i will check it |
Collaborator
Author
|
CI didn't run on this because of the issue, but it does pass on the repo this is being made from |
gsemet
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlighted in and fixes #1796. Also removed comments that won't be true or relevant with this change. These changes orphan the
execute_command_by_uuid()method, but the method can probably still be used elsewhere, maybe given a command line flag like whatexecute_command()has.