Skip to content

Revert "Revert "doc: update NEWS.rst"" - #2015

Closed
gsemet wants to merge 2 commits into
masterfrom
dev/gsemet
Closed

Revert "Revert "doc: update NEWS.rst""#2015
gsemet wants to merge 2 commits into
masterfrom
dev/gsemet

Conversation

@gsemet

@gsemet gsemet commented Jan 19, 2022

Copy link
Copy Markdown
Member

This reverts commit d5c5811.

@gsemet

gsemet commented Jan 19, 2022

Copy link
Copy Markdown
Member Author

@Davidy22 this reverts the revert and fix the yaml issue. And the pipeline is green :D

@Davidy22 Davidy22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original commit had more wrong with it than just the yaml breakage, by the time we've fixed that this PR isn't a reversion anymore so this PR needs to be renamed.

Comment thread NEWS.rst
3.8.2
=====

Release Summary

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this all deleted? Is this file being generated with make release-note? This is completely different from the file that I'm seeing it generate and if there's any manual changes you're making to this output file, they are going to be overwritten the next time make release-note gets run.

@Davidy22

Davidy22 commented Feb 3, 2022

Copy link
Copy Markdown
Collaborator

Superceded by #2024

@Davidy22 Davidy22 closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants