feature: --is-visible option #1926 - #2008
Merged
Merged
Conversation
Collaborator
|
I've just clicked approve for the non-deepsource CI items, and it looks like there's some things that deepsource wants to highlight for fixing as well. I'll take a deeper look after the CI moans are dealt with |
Contributor
Author
|
Yeah I think the mergeable-if-statement flags have been around for a bit since they appear in this PR from back in November. The unnecessary comment flags seem to be new though. |
Davidy22
approved these changes
Jan 16, 2022
Davidy22
left a comment
Davidy22
left a comment
Collaborator
There was a problem hiding this comment.
Hum, went in and looked and it does look the CI moans don't have anything to do with your code, not sure why deepsource has decided to do this or how these didn't get raised earlier, but I'll go in and clean that up later. For now, took a look at the code, looks fine and works as expected so I'll merge.
This was referenced Jan 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the --is-visible option suggested in #1926. Screenshots are a from the build on a clean install of Fedora.
True:
False: