Fix upload to pypi test - #2002
Merged
Merged
Conversation
Collaborator
Author
|
Merging to get this in because it's pretty important and I'd have to wait weeks otherwise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After much discouragement from the last several unfruitful attempts to make pypi happen, I fell off a little bit and was busy elsewhere but found it in me recently to get over and take a look at the repo, which had a failing CI build that I somehow failed to notice for ages. Looking at the specifics of the failure, this seems actually encouragingly like a working pypi build is finally in reach, just need to strip out some elements from the version number that pypi can't handle.