Skip to content

Fix module gi not found when make run - #1989

Merged
gsemet merged 3 commits into
Guake:masterfrom
jcfstabile:fix/gi-not-found-on-run-local
Dec 15, 2021
Merged

Fix module gi not found when make run #1989
gsemet merged 3 commits into
Guake:masterfrom
jcfstabile:fix/gi-not-found-on-run-local

Conversation

@jcfstabile

@jcfstabile jcfstabile commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

Please follow these steps before submitting a new Pull Request to Guake:

  • rebase on latest HEAD:

    $ git pull --rebase upstream master

  • hack your change

  • to execute the code styling, checks and unit tests:

    $ make style check reno-lint test

  • describe your change in a slug file for automatic release note
    generation, using:

    $ make reno SLUG=<short_name_of_my_feature>

    and edit the created file in releasenotes/notes/.
    You can see how reno works using pipenv run reno --help.

    Please use a generic slug (eg, for translation update,
    use translation, for bugfix use bugfix,...)

  • create new commit message

    $ <hack the code>
$ git commit --all

  • If your change is related to a GitHub issue, you can add a reference
    using #123 where 123 is the ID of the issue.
    You can use closes #123 to have GitHub automatically close the issue
    when your contribution get merged

  • Semantic commit is supported (and recommended). Add one of the following
    line in your commit messages:

    # For a bug fix, uses:
sem-ver: bugfix

# For a new feature, uses:
sem-ver: feature

# Please do not use the 'breaking change' syntax (`sem-ver: api-break`), 
# it is reserved for really big reworks

@jcfstabile jcfstabile mentioned this pull request Dec 15, 2021
Open
@mlouielu

mlouielu commented Dec 15, 2021

Copy link
Copy Markdown
Collaborator

It works, but I would like some comment from @gsemet to know the historical reason we did not put pygobject and dbus-python in pipfile.

@Davidy22

Davidy22 commented Dec 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Well, the CI failure's probably pointing us in the direction of the reason. The first few times I threw myself at the build system are still smarting, I'll take another crack or two since someone else is going in on it too.

@gsemet

gsemet commented Dec 15, 2021

Copy link
Copy Markdown
Member

I do not remember well, I think these packages did not exited at all and we requires system packages (it makes sense, gtk it tightly linked to system dependencies).

@gsemet
gsemet merged commit 3230199 into Guake:master Dec 15, 2021
@Davidy22

Davidy22 commented Dec 15, 2021

Copy link
Copy Markdown
Collaborator

Wait, why was this pulled? It failed CI, don't we need to fix that first?

@gsemet

gsemet commented Dec 15, 2021

Copy link
Copy Markdown
Member

Sorry I though this fixed something. Should we revert?

@jcfstabile

jcfstabile commented Dec 16, 2021

Copy link
Copy Markdown
Contributor Author

Hi. Think I found a fix for the CI failure. Downgrade pipenv to 2021.5.29 had solved the failure on local CI runs. Should I submit a new PR?

@mlouielu

mlouielu commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

Hi. Think I found a fix for the CI failure. Downgrade pipenv to 2021.5.29 had solved the failure on local CI runs. Should I submit a new PR?

Sure, please do it, and maybe we need to find out why 2021.11.23 cannot work and report to pipenv upstream.

@jcfstabile

jcfstabile commented Dec 16, 2021

Copy link
Copy Markdown
Contributor Author

Ok.

@mlouielu

mlouielu commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

@Davidy22 what about revert, and check the solution again?

I think we should add pygobject and dbus-python into -dev dependencies.

@Davidy22

Davidy22 commented Dec 16, 2021

Copy link
Copy Markdown
Collaborator

Since there's a PR open for fixing CI I'd probably just work in there to get it passing again. We can add things that'll make checks pass in there too.

@mlouielu

mlouielu commented Dec 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

I'll have a revert (#1989) for #1991, and we can revise this in #1990 or update with poetry.

@mlouielu mlouielu mentioned this pull request Dec 17, 2021
Merged
@Davidy22 Davidy22 mentioned this pull request Dec 19, 2021
Merged
@mlouielu mlouielu mentioned this pull request Jan 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gsemet gsemet gsemet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jcfstabile @mlouielu @Davidy22 @gsemet