Changed default keybindig to toggle hide on lose focus. Fix #1719 - #1988
Merged
Conversation
Resolve: Ctrl+F1 does two jobs in Keyboard Shortcuts Page Guake#1719
Resolve: Ctrl+F1 does two jobs in Keyboard Shortcuts Page Guake#1719
…ake into fix/toggle-hide-keybinding
Davidy22
approved these changes
Dec 15, 2021
Davidy22
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, passes CI, works on my machine, merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve: Ctrl+F1 does two jobs in Keyboard Shortcuts Page #1719
Please follow these steps before submitting a new Pull Request to Guake:
rebase on latest HEAD:
hack your change
to execute the code styling, checks and unit tests:
$ make style check reno-lint testdescribe your change in a slug file for automatic release note
generation, using:
and edit the created file in
releasenotes/notes/.You can see how
renoworks usingpipenv run reno --help.Please use a generic slug (eg, for translation update,
use
translation, for bugfix usebugfix,...)create new commit message
If your change is related to a GitHub issue, you can add a reference
using
#123where 123 is the ID of the issue.You can use
closes #123to have GitHub automatically close the issuewhen your contribution get merged
Semantic commit is supported (and recommended). Add one of the following
line in your commit messages: