Skip to content

Changed default keybindig to toggle hide on lose focus. Fix #1719 - #1988

Merged
Davidy22 merged 3 commits into
Guake:masterfrom
jcfstabile:fix/toggle-hide-keybinding
Dec 15, 2021
Merged

Changed default keybindig to toggle hide on lose focus. Fix #1719#1988
Davidy22 merged 3 commits into
Guake:masterfrom
jcfstabile:fix/toggle-hide-keybinding

Conversation

@jcfstabile

Copy link
Copy Markdown
Contributor

Resolve: Ctrl+F1 does two jobs in Keyboard Shortcuts Page #1719

Please follow these steps before submitting a new Pull Request to Guake:

  • rebase on latest HEAD:

    $ git pull --rebase upstream master
  • hack your change

  • to execute the code styling, checks and unit tests:

    $ make style check reno-lint test
  • describe your change in a slug file for automatic release note
    generation, using:

    $ make reno SLUG=<short_name_of_my_feature>

    and edit the created file in releasenotes/notes/.
    You can see how reno works using pipenv run reno --help.

    Please use a generic slug (eg, for translation update,
    use translation, for bugfix use bugfix,...)

  • create new commit message

    $ <hack the code>
    $ git commit --all
  • If your change is related to a GitHub issue, you can add a reference
    using #123 where 123 is the ID of the issue.
    You can use closes #123 to have GitHub automatically close the issue
    when your contribution get merged

  • Semantic commit is supported (and recommended). Add one of the following
    line in your commit messages:

    # For a bug fix, uses:
    sem-ver: bugfix
    
    # For a new feature, uses:
    sem-ver: feature
    
    # Please do not use the 'breaking change' syntax (`sem-ver: api-break`), 
    # it is reserved for really big reworks
    

Resolve: Ctrl+F1 does two jobs in Keyboard Shortcuts Page Guake#1719
Resolve: Ctrl+F1 does two jobs in Keyboard Shortcuts Page Guake#1719

@Davidy22 Davidy22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, passes CI, works on my machine, merging

@Davidy22
Davidy22 merged commit cca0643 into Guake:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants