Add pbr fallback - #1964
Merged
Merged
Conversation
Resolves Guake#1962
mlouielu
approved these changes
Nov 14, 2021
mlouielu
left a comment
mlouielu
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, this should be work for previous version of Python.
Collaborator
|
BTW, I think we should add smoke test in CI, as they didn't manage to discover in 3.6, 3.7 test |
Collaborator
Author
|
Yeah this is probably fairly easy to add a unit test for. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1962
pbr seems to be an unused dependency after it was removed from the code, but this brings it back into use for at least until python versions < 3.8 get well and truly EOL'd