fix:Do not set GDK_BACKEND to x11 in terminals. - #1911
Merged
Conversation
Davidy22
changed the title
Davidy22
force-pushed
the
gdk_backend
branch
2 times, most recently
from
September 27, 2021 06:05
c469460 to
3176b24
Compare
mlouielu
requested changes
Sep 29, 2021
|
|
||
| self.setup_drag_and_drop() | ||
|
|
||
| exclude = {"GDK_BACKEND"} |
Collaborator
There was a problem hiding this comment.
we may put this as a constant?
self.ENVV_EXCLUDE_LIST = ["GDK_BACKEND"]
Collaborator
Author
There was a problem hiding this comment.
Alright, sure, could be useful at some point.
Davidy22
force-pushed
the
gdk_backend
branch
from
September 30, 2021 03:06
3176b24 to
09a2b48
Compare
mlouielu
requested changes
Oct 1, 2021
mlouielu
left a comment
mlouielu
left a comment
Collaborator
There was a problem hiding this comment.
Function test pass, LGTM.
Only a small point, please help remove duplicate commit title in commit message.
Collaborator
Author
|
Done. |
mlouielu
previously approved these changes
Oct 1, 2021
Don't automatically inherit env variables and manually pass modified env Fixes Guake#1871
Collaborator
Author
|
eh alright done |
Collaborator
|
I just find out that merge commit will be editable after I click merge..., so basically my last request can be added in merge commit next time 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not set GDK_BACKEND to x11 in terminals.
Don't automatically inherit env variables and manually pass modified env
Fixes #1871