feat:Add hide tab bar when only one tab option - #1873
Merged
Conversation
Davidy22
changed the title
Collaborator
|
Would you like to add unit test (at least to test preference) for this? |
mlouielu
requested changes
Sep 9, 2021
Collaborator
Author
|
Pushed changes to address review, can do test cases later |
Collaborator
Author
|
a real quick test case added in |
Collaborator
|
Consider to consist the tag name and function name, maybe |
mlouielu
reviewed
Sep 10, 2021
mlouielu
reviewed
Sep 10, 2021
Collaborator
Author
|
Alright I renamed it to be a little closer to how I called it in the option. |
Also tied hide tab bar to some related menu options.
Remove translation section because irrelevant and breaks checks and I apparently don't know how to format it
Member
|
Can you tell me if this PR is still relevant? |
Collaborator
Author
|
Still works as intended, there might be a merge conflict in prefs.glade because other things that change preferences layout have been merged since this was created but I'm otherwise a go to have this finally merged if there's no merge conflict. |
mlouielu
self-requested a review
September 16, 2021 12:09
mlouielu
approved these changes
Sep 16, 2021
Collaborator
|
LGTM, #1896 can wait on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also tied hide tab bar to some related menu options.
Resolves #924 and potentially other related issues