Skip to content

fix: #1761 guake follows mouse focus when have 2 monitors - #1775

Merged
gsemet merged 3 commits into
Guake:masterfrom
woodpenker:master
May 14, 2021
Merged

fix: #1761 guake follows mouse focus when have 2 monitors#1775
gsemet merged 3 commits into
Guake:masterfrom
woodpenker:master

Conversation

@woodpenker

Copy link
Copy Markdown
Contributor

Fix #1761 When Appear on mouse display open for Version 3.7.0 on a dual-screen desktop, the Guake window moves to the other screen if lost focus. This pr is to avoid this annoying situation.

jidar
jidar previously approved these changes Jul 1, 2020
@jidar

jidar commented Jul 1, 2020

Copy link
Copy Markdown

I have confirmed that this fixes the stated problem.

@borian

borian commented Aug 6, 2020

Copy link
Copy Markdown

Thanks for the PR. This fixed the Problem.

It can be manually fixed in /lib/python3.8/site-packages/guake/utils.py until this is merged.This bug has been really annoying

@simonmarwitz

Copy link
Copy Markdown

The manual fix works. However fails, when guake is in the background and other windows are open. Once the last other window is minimized, the terminal switches to the mouse display. This is different than the previous behavior. I tried to find a solution but could not come up with a way to differentiate the two cases, where the terminal gets focus actively (by hotkey) or passively (simply by closing/minimizing all remaining windows).

@woodpenker

Copy link
Copy Markdown
Contributor Author

The manual fix works. However fails, when guake is in the background and other windows are open. Once the last other window is minimized, the terminal switches to the mouse display. This is different than the previous behavior. I tried to find a solution but could not come up with a way to differentiate the two cases, where the terminal gets focus actively (by hotkey) or passively (simply by closing/minimizing all remaining windows).

Thanks for your feed back. I reproduced your situation and find a way may fix this: Only do unfullscreen when guake is hidden. I test it on my desktop, it seems works well now.

@cybik

cybik commented Oct 6, 2020

Copy link
Copy Markdown

Raising this PR from the depths. It seems to fix the following glitch here as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

guake follows mouse focus when have 2 monitors

6 participants