Skip to content

Security fix breaks guake -e #2042

Description

@midnight-wonderer

In version 3.8.5, execute_command has been removed from DBus
#1796

The discussion there implies that -e option won't affect by this change.
In reality, it does break the functionality

Here the stack trace

Traceback (most recent call last):
  File "$HOME/.local/bin/guake", line 8, in <module>
    sys.exit(exec_main())
  File "$HOME/.local/lib/python3.10/site-packages/guake/main.py", line 633, in exec_main
    if not main():
  File "$HOME/.local/lib/python3.10/site-packages/guake/main.py", line 552, in main
    remote_object.execute_command(options.command)
  File "$HOME/.local/lib/python3.10/site-packages/dbus/proxies.py", line 72, in __call__
    return self._proxy_method(*args, **keywords)
  File "$HOME/.local/lib/python3.10/site-packages/dbus/proxies.py", line 141, in __call__
    return self._connection.call_blocking(self._named_service,
  File "$HOME/.local/lib/python3.10/site-packages/dbus/connection.py", line 652, in call_blocking
    reply_message = self.send_message_with_reply_and_block(
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.UnknownMethod: Traceback (most recent call last):
  File "$HOME/.local/lib/python3.10/site-packages/dbus/service.py", line 662, in _message_cb
    (candidate_method, parent_method) = _method_lookup(self, method_name, interface_name)
  File "$HOME/.local/lib/python3.10/site-packages/dbus/service.py", line 254, in _method_lookup
    raise UnknownMethodException('%s is not a valid method' % method_name)
dbus.exceptions.UnknownMethodException: org.freedesktop.DBus.Error.UnknownMethod: Unknown method: execute_command is not a valid method

To reproduce, simply try -e option.

$guake --support

<details><summary>$ guake --support</summary>

Guake Version:		3.8.5

Vte Version:		0.60.3

Vte Runtime Version:	0.60.3

--------------------------------------------------
GTK+ Version:		3.24.20

GDK Backend:		<GdkX11.X11Display

--------------------------------------------------
Desktop Session: gnome

--------------------------------------------------
Display: :0

RGBA visual: True

Composited: True

* Monitor: 0 - XWAYLAND0
    * Geometry:		1920 x 1080 at 0, 0
    * Size:		480 x 270 mm²
    * Primary:		True
    * Refresh rate:	59.962 Hz
    * Subpixel layout:	unknown

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions