Conversation
…ging a commit conflict to the object log, we'll just pass the url of the native request ... unless the GsSocket is sneaking into a persistent root some other (less obvious way) ... logging commit conflicts should now be safe and hopefully the FastCGI-related GsSocket "lost state" errors nuked
Member
Author
Contributor
|
@dale, looks good, will try the patch asap! On Tue, Apr 7, 2015 at 12:28 AM, Dale Henrichs [email protected]
|
Member
|
Nice catch. Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@obi068 and @jbrichau, I'm pretty sure that we've nuked the major cause of
the object aGsSocket that has some associated session state has losterrors.Despite the extra newlines and reformatting, the operative change was here which I think should eliminate a bunch of
the object aGsSocket that has some associated session state has losterrors especially if you can correlate the socket error with a commit conflict log entry ...I'll hold off merging this PR until I get feedback from you guys ...