GSF.PhasorProtocols: [CFG-3] Assign appropriate values to ConversionFactor and MagnitudeMultiplier#452
Merged
StephenCWills merged 1 commit intomasterfrom Nov 26, 2025
Merged
Conversation
…actor and MagnitudeMultiplier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConversionFactoris used to scale data when reading/writing phasor values.MagnitudeMultiplieris used when reading/writingPHSCALEvalues in the configuration frame.When generating a fixed-integer IEEE C37.118-2011 data stream,
ConversionFactorandMagnitudeMultipliershould be the same so that the phasor magnitudes can be scaled by the appropriate multiplier and then that same multiplier can be encoded into the config frame.When parsing a fixed-integer IEEE C37.118-2011 data stream,
ConversionFactorshould be 1 in order to assign the raw phasor magnitude to theMeasurement.Valuefield. TheMagnitudeMultipliershould be assigned to theMeasurement.Multiplierfield during input device configuration so that the scaled value can be accessed at runtime viaMeasurement.AdjustedValue.This logic should only apply to phasors since
PhasorValueBaseis the only class that is usingConversionFactorfor scaling during parsing/generation.